Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/866 archive #930

Merged
merged 12 commits into from
Aug 18, 2023
Merged

Enhancement/866 archive #930

merged 12 commits into from
Aug 18, 2023

Conversation

fernandofloresg
Copy link
Collaborator

SUMMARY

post beta changes that ship multiple enhancements:

  • When xmit faces a space error in xmit operation because of dest or log data set are filled raises an appropriate error hint.
  • If destination data set space is not provided then the module computes it based on the src list and/or expanded src list based on pattern provided.
  • When using zos_unarchive and copy to remote fails now a proper error message is displayed.
  • When using zos_unarchive and copying to remote if space_primary is not defined, then is defaulted to 5M.
  • Fixed a bug that did not returned proper src state after archiving, now it displays the status of the src after the operation.
  • Reduced some record length parametrization in tests.
  • Added a test for when copy to remote fails.

Fixes #866
Fixes #864
Fixes #865

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

zos_archive
zos_unarchive

@fernandofloresg
Copy link
Collaborator Author

Screenshot 2023-08-16 at 9 47 05 AM

richp405
richp405 requested changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@richp405 richp405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change in documentation. Code looks fine.

richp405
richp405 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@richp405 richp405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

rexemin
rexemin approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@rexemin rexemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Changing the checksum for USS files was a good call, and thanks for adding better error messages.

AndreMarcel99
AndreMarcel99 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@AndreMarcel99 AndreMarcel99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to follow

@fernandofloresg fernandofloresg mentioned this pull request Aug 18, 2023
Closed
1 task
ketankelkar
ketankelkar requested changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@ketankelkar ketankelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! just a few comments on doc stuff and it looks good to go!

ketankelkar
ketankelkar approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@ketankelkar ketankelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the doc changes, LGTM!

@fernandofloresg fernandofloresg merged commit 5995543 into staging-v1.7.0-beta.2 Aug 18, 2023
fernandofloresg added a commit that referenced this pull request Aug 24, 2023
@fernandofloresg
Staging v1.7.0 beta.2 (#939)
215033d 
* Enhancement/866 archive (#930)

* Added action plugin zos_unarchive

* Added zos_archive changes

* Added zos_unarchive changes

* Added zos_archive tests changes

* Added test zos_unarchive changes

* Added zos_archive changes

* fixed pep8 issues

* Changed source to src in docs

* Added correct copyright year

* Updated docs

* Added changelog fragments

* Updated docs

* Updated galaxy.yml

* Updated meta

* Updated docs

* Added zos_gather_facts rst

* Added changelog

* Added release notes

* Changed variable name to avoid shadowing import

* Delete 930-archive-post-beta.yml

* Delete v1.7.0-beta.2_summary.yml
@ddimatos ddimatos deleted the enhancement/866-archive branch October 19, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ketankelkar ketankelkar ketankelkar approved these changes

@rexemin rexemin rexemin approved these changes

@richp405 richp405 richp405 approved these changes

@AndreMarcel99 AndreMarcel99 AndreMarcel99 approved these changes

@ddimatos ddimatos Awaiting requested review from ddimatos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fernandofloresg @ketankelkar @rexemin @richp405 @AndreMarcel99