Bugfix/374/module zos mvs raw errors with long multi line quoted string in content field

[AndreMarcel99]

SUMMARY

Add validations and fixes for proper ways of written multiline texts in playbooks for a JCL

Fixes #374 and #665

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

modify_contetns
add_spaces

ADDITIONAL INFORMATION

modify_contents:

• If content is a list is just required to be validate with add spaces function an then be join with /n

• If content is a string add spaces at the beginning if necessary then split into a list for every new line and pass to add_spaces function

add_spaces: with a list check every line the len if exceed the 78 characters would throw error if not add double spaces at the beginning if is not already to validate for a correct JCL

*note: All the changes will affect correct ways of writing multi lines text in yaml as:

content: |1
                INCLUDE INLIB
                NAME {{ MEM_TEST }}(R)
content: |
                INCLUDE INLIB
                NAME {{ MEM_TEST }}(R)
content:
                - "INCLUDE INLIB"
                - "NAME {{ MEM_TEST }}(R)"

[fernandofloresg]

I will paste my comments on the slack thread since I see some were ignored:

Due to JCL constraints with input data set
Issue 1: JCL content currently cannot be longer than 80 chars
Document this in our module, it is stated in the MVS JCL User guide and we can not modify that behavior, indicate how the user can input multiline yaml texts to not remove newline chars.

Issue 2: Us prepending spaces in each newline
I like your proposal and would like to see the code for it, you got my green light for it, what I think we could do is do it the smart way, just add the needed empty spaces if those are not already in place.

This is missing some needed documentation on how we will handle user JCL input from now on, that is very important so users just don't see random record length errors with the new release.

On another front, I will prefer that we only prepend empty spaces when is absolutely needed.

I also added a strange error that I come up while testing a new added code, be sure to test new functionality that you add even if regression tests run fine because we most likely don't have a testing case for that new functionality.

And since we are adding a new functionality, a new test case would be welcomed.

[richp405]

This looks decent. I left a question and a suggestion for the changelog fragment.

[AndreMarcel99]

[richp405]

Looks okay...make sure you check fernando's last comment.

[AndreMarcel99]

[ddimatos]

I think we still need a bit of work @AndreMarcel99 , I would also suggest that we maybe add an example using a block sytle indicator with 2 , eg `content: | 2" , pretty sure I had some examples in the original git issues I created you can pull from. They don't have to be lengthy examples but its good if we show one.

I don't think we can automate with the block style indicator with the pytest-ansible , maybe share a couple of examples in the pull request from the ones I created or ones of your own for historical purposes?

[AndreMarcel99]

[ddimatos]

LGTM, thank you.