fixup: cmci int tests retries and program install timeouts #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes the timeouts in the cmci integration tests. When a program install takes too long for one request we were retrying when the task failed. If the program hasnt finished installing the ansible task would return a CPSM nodata response but the task would also succeed (failed = false). This means we wouldnt retry the task and hence fail the assertion.
This fix allows us to retry if we get a nodata response up to 5 times (I increased this from 3 as it consistently takes at least 3 attempts at the moment so thought I would give us a ,little more retry-ability). This means the test will also fail if the first task returns a failed status which is more accurate for a failing scenario
ISSUE TYPE