Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: drop support for ansible-core 2.13 #450

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

jooola
Copy link
Collaborator

@jooola jooola commented Feb 2, 2024

@jooola
Copy link
Collaborator Author

jooola commented Feb 2, 2024

We could wait for the 20 May 2024 to drop both ansible 2.14 and 2.13 and have a single major release.

@apricote
Copy link
Collaborator

apricote commented Feb 2, 2024

We could wait for the 20 May 2024 to drop both ansible 2.14 and 2.13 and have a single major release.

Fine by me.

Is there anything to gain from using Python 3.9 features now? (Ansible 2.13 requires support with Python 3.8, 2.14 does not)

@jooola
Copy link
Collaborator Author

jooola commented Feb 2, 2024

Is there anything to gain from using Python 3.9 features now? (Ansible 2.13 requires support with Python 3.8, 2.14 does not)

We are still constrained by the python EOL policy that we follow for the hcloud-python library. Maybe we can start using some new feature from ansible-core 2.14, but I think nothing is needed/required right now (maybe some docs improvements).

@jooola jooola marked this pull request as ready for review February 5, 2024 11:19
@jooola jooola requested a review from apricote February 5, 2024 11:19
@jooola jooola force-pushed the drop-ansible-2.13-support branch from 41e8236 to 80112df Compare February 5, 2024 11:19
@jooola
Copy link
Collaborator Author

jooola commented Feb 5, 2024

We will release a new major version anyway, so this is good to go!

@jooola jooola force-pushed the drop-ansible-2.13-support branch from 80112df to e44907d Compare February 5, 2024 11:28
@jooola jooola merged commit 96f8009 into ansible-collections:main Feb 5, 2024
25 checks passed
@jooola jooola deleted the drop-ansible-2.13-support branch February 5, 2024 13:26
jooola pushed a commit that referenced this pull request Feb 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.0.0](2.5.0...3.0.0)
(2024-02-05)


### ⚠ BREAKING CHANGES

* drop support for ansible-core 2.13
([#450](#450))
* always return iso-8601 formatted date time
([#453](#453))
* remove inventory `api_token_env` option
([#454](#454))

### Features

* drop support for ansible-core 2.13
([#450](#450))
([96f8009](96f8009)),
closes
[#400](#400)
* **inventory:** allow templating instances hostname
([#455](#455))
([be404ef](be404ef))
* remove inventory `api_token_env` option
([#454](#454))
([d0c82ae](d0c82ae))


### Bug Fixes

* allow renaming networks
([#449](#449))
([742cfe6](742cfe6))
* always return iso-8601 formatted date time
([#453](#453))
([55d2616](55d2616))
* load balancer invalid cookie lifetime value returned
([#452](#452))
([86b7662](86b7662))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for ansible-core 2.13
2 participants