feat: allow forcing the deletion of firewalls that are still in use #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the firewall is still in use, the api will prevent deleting the firewall. This makes sure that we don't silence this error, while keeping the previous race condition fix.
jooola
changed the title
apricote
approved these changes
Feb 2, 2024
jooola
pushed a commit
that referenced
this pull request
Feb 2, 2024
🤖 I have created a release *beep* *boop* --- ## [2.5.0](2.4.1...2.5.0) (2024-02-02) ### Features * add `hostvars_prefix` and `hostvars_suffix` options to inventory hostvars ([#423](#423)) ([4e3f89a](4e3f89a)) * allow forcing the deletion of firewalls that are still in use ([#447](#447)) ([559d315](559d315)) * improve firewall resources management ([#324](#324)) ([2757fe7](2757fe7)) * replace `ansible.netcommon` utils with python3 `ipaddress` module ([#416](#416)) ([4cfdf50](4cfdf50)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #380
ISSUE TYPE
COMPONENT NAME
firewall