feat: vendor hcloud python dependency

[jooola]

SUMMARY

This PR vendors the hcloud python dependency inside the ansible collection.

Fixes #211
Fixes #217
Fixes #218

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

module_utils

[webknjaz]

@jooola so I looked into this PR and have a few points to make:

1. Using pre-commit is probably not right fit for this kind of check since it's expensive. Dropping it from this tool would allow for blazing fast checks with pre-commit.ci. It should be fine to have it separate because vendoring is a manually triggered process. Every PR doesn't need to run it.
2. It seems like the script here reinvents the wheel. Instead, I'd recommend relying on prior art. Specially, why not use the project that is called vendoring — it grew out of pip and is now available as a standalone distribution. Pip still uses it, of course. AFAIK, it also allows patching the vendored projects in a generic manner too.
3. I'd check if it's possible to integrate this into ansible-test sanity. ansible/ansible has a special location for such linters but I don't remember if this mechanism is supported in collections...

[jooola]

Oh nice, I didn't know about vendoring. I just tried to understand the tool, and sadly it is lacking the first bits of documentation. The CLI isn't describing itself either.

In addition, in the README I read: "This tool has no stability promises -- it has only one intended user: pip"

So I think I'd prefer to stay away from this tool, and use a simple script with no dependency.

I am not sure to understand what "this" is referring to. Could you elaborate please?

[webknjaz]

I am not sure to understand what "this" is referring to. Could you elaborate please?

This==your vendoring check.
ansible-core has this directory https://github.com/ansible/ansible/tree/devel/test/sanity/code-smell. And ansible-test sanity picks up the scripts put there. I was hoping this is also supported for collections, which would make it a better place for putting your vendoring script.

[webknjaz]

Oh nice, I didn't know about vendoring. I just tried to understand the tool, and sadly it is lacking the first bits of documentation. The CLI isn't describing itself either.

It's integrated somewhere in noxfile.py, it shouldn't be too hard to figure it out, if you're interested..

In addition, in the README I read: "This tool has no stability promises -- it has only one intended user: pip"

True, though this is solvable by pinning it to a precise version that works for you.

[webknjaz]

It's integrated somewhere in noxfile.py, it shouldn't be too hard to figure it out, if you're interested..

Here's some calls: https://github.com/pypa/pip/blob/b88adde/noxfile.py#L198-L243.

Here's some docs: https://github.com/pypa/pip/tree/b88adde/src/pip/_vendor#automatic-vendoring

[jooola]

@webknjaz I appreciate the links, but we will not be using the vendoring tool for the reasons I already stated.

Regarding the pre-commit point (1.), I prefer to move the discussion to a separate issue, so we don't mix everything up. We can always remove this pre-commit hook in the future.

[jooola]

Hi @resmo @felixfontein, if you find some time, could I have a small review please? This PR should fix #211 #217 #218

[apricote]

🥳 Works for me!