feat(inventory): handle servers that dont work with connect_with setting [2/3] #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKaemmerling
previously approved these changes
Jan 30, 2023
apricote
force-pushed
the
inventory-2-handle-invalid-connect-with
branch
from
cd25d48 to
7c14255
Compare
This was referenced Jan 30, 2023
apricote
force-pushed
the
inventory-1-private-networks-info
branch
from
011bf75 to
b491741
Compare
apricote
force-pushed
the
inventory-2-handle-invalid-connect-with
branch
from
7c14255 to
12983df
Compare
apricote
force-pushed
the
inventory-1-private-networks-info
branch
from
b491741 to
a85d6b9
Compare
apricote
force-pushed
the
inventory-2-handle-invalid-connect-with
branch
from
12983df to
aa84ac2
Compare
apricote
force-pushed
the
inventory-2-handle-invalid-connect-with
branch
from
aa84ac2 to
d8b9f50
Compare
Currently if any of the servers in the inventory do not work with the selected `connect_with` mode, the script exits and returns 0 servers. This can happen for example if one of your servers does not have a public ipv4 address, but you set `connect_with: public_ipv4` (default). This commit changes the behaviour to log a warning message, and just skip setting `ansible_host` for this server. This server will not be reachable by ansible by default, but users can use `compose` to override the `ansible_host` that we set based on the other variables.
apricote
force-pushed
the
inventory-2-handle-invalid-connect-with
branch
from
d8b9f50 to
a536ecf
Compare
LKaemmerling
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently if any of the servers in the inventory do not work with the selected
connect_withmode, the script exits and returns 0 servers. This can happen for example if one of your servers does not have a public ipv4 address, but you setconnect_with: public_ipv4(default).This commit changes the behaviour to log a warning message, and just skip setting
ansible_hostfor this server. This server will not be reachable by ansible by default, but users can usecomposeto override theansible_hostthat we set based on the other variables.Related to #178
Rebased on #186
Part of a 3 PR series:
ISSUE TYPE
COMPONENT NAME
Inventory Plugin
ADDITIONAL INFORMATION
/