Fix hcloud_network_info failing with Servers without internet connectivity #159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for providing the Ansible community with an easy way to manage their HCloud infrastructure.
I'm opening this PR on behalf of the company I work for, Peerox GmbH.
Best regards,
Konstantin Köhring
SUMMARY
This fixes the behavior if there is a server without direct internet connectivity in the examined network.
Previously, the module would throw an AttributeError because server.public_net.ipv4/ipv6 is None in this case. Now the None propagates correctly.
Fixes #155
ISSUE TYPE
COMPONENT NAME
hetzner.hcloud.network_info module
ADDITIONAL INFORMATION
Steps to reproduce:
hetzner.hcloud.hcloud_network_info
with{"name": "NAME_OF_THE_PRIVATE_NETWORK"}
before:
after: