Inventory plugin: Allow token to be provided through extra-vars.

[n00b42]

SUMMARY

Allow token to be provided through extra-vars.
Allows "dynamic" insertion of the token without changing the environment variables

Fixes #181

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

hetzner.hcloud.hcloud

ADDITIONAL INFORMATION

Only thing I am not perfectly sure about is, if one can safely use self._compose and self._compose in a custom plugin.

[apricote]

Hey @n00b42, thanks for the contribution!

This fails for me with the nested extra var:

[WARNING]:  * Failed to parse ./hcloud.yaml with auto plugin: 'hetzner' is undefined

It works if I use hetzner_apitoken instead (or any other value that does not use a dot)

[apricote]

We already support templating logic when evaluating token. What is missing from that, is that the extra vars are not passed to self.templar.template. self._compose() under the hood passes those variables and then calls self.templar.template.

To avoid templating twice with nearly the same logic, what do you think about adding the self._vars to our templar instance?

self.templar.available_variables = self._vars
self.api_token = self.templar.template(self.get_option("token"), fail_on_undefined=False) or os.getenv(self.token_env)

Then you can use the (extra) vars in the normal token templating:

token: "{{ hcloud_token }}"

[n00b42]

I am fine with that as well, just needed a way to pass it using a variable.
Should I update the PR or will you do the changes yourself?

[apricote]

I am fine with that as well, just needed a way to pass it using a variable. Should I update the PR or will you do the changes yourself?

It would be great if you can update the PR, but I can also do it if you have no time.

[n00b42]

changed as suggested.