Skip to content

Commit

Permalink
Add back requireds on stripquery (#3443) (#215)
Browse files Browse the repository at this point in the history
* Add back requireds on stripquery

* Move required to terraform.yaml, add description on empty blocks'

* Fixed to preserve backwards compatibility

* Remove last default in description

* Default back to false in ansible urlmaps

Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored May 1, 2020
1 parent 384a8f4 commit 9bfffd5
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 22 deletions.
16 changes: 8 additions & 8 deletions plugins/modules/gcp_compute_region_url_map.py
Original file line number Diff line number Diff line change
Expand Up @@ -925,8 +925,8 @@
description:
- If set to true, any accompanying query portion of the original URL
is removed prior to redirecting the request. If set to false, the
query portion of the original URL is retained. The default is set
to false.
query portion of the original URL is retained. The default value
is false.
required: false
default: 'false'
type: bool
Expand Down Expand Up @@ -1483,7 +1483,7 @@
description:
- If set to true, any accompanying query portion of the original URL is
removed prior to redirecting the request. If set to false, the query
portion of the original URL is retained. The default is set to false.
portion of the original URL is retained.
required: false
default: 'false'
type: bool
Expand Down Expand Up @@ -1582,7 +1582,7 @@
description:
- If set to true, any accompanying query portion of the original URL is removed
prior to redirecting the request. If set to false, the query portion of
the original URL is retained. The default is set to false.
the original URL is retained.
required: false
default: 'false'
type: bool
Expand Down Expand Up @@ -2494,8 +2494,8 @@
description:
- If set to true, any accompanying query portion of the original URL
is removed prior to redirecting the request. If set to false, the
query portion of the original URL is retained. The default is set
to false.
query portion of the original URL is retained. The default value is
false.
returned: success
type: bool
pathRules:
Expand Down Expand Up @@ -3005,7 +3005,7 @@
description:
- If set to true, any accompanying query portion of the original URL is
removed prior to redirecting the request. If set to false, the query portion
of the original URL is retained. The default is set to false.
of the original URL is retained.
returned: success
type: bool
tests:
Expand Down Expand Up @@ -3094,7 +3094,7 @@
description:
- If set to true, any accompanying query portion of the original URL is removed
prior to redirecting the request. If set to false, the query portion of the
original URL is retained. The default is set to false.
original URL is retained.
returned: success
type: bool
region:
Expand Down
7 changes: 3 additions & 4 deletions plugins/modules/gcp_compute_region_url_map_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,7 @@
- If set to true, any accompanying query portion of the original
URL is removed prior to redirecting the request. If set to false,
the query portion of the original URL is retained. The default
is set to false.
value is false.
returned: success
type: bool
pathRules:
Expand Down Expand Up @@ -1484,8 +1484,7 @@
description:
- If set to true, any accompanying query portion of the original URL
is removed prior to redirecting the request. If set to false, the
query portion of the original URL is retained. The default is set
to false.
query portion of the original URL is retained.
returned: success
type: bool
tests:
Expand Down Expand Up @@ -1575,7 +1574,7 @@
description:
- If set to true, any accompanying query portion of the original URL is
removed prior to redirecting the request. If set to false, the query portion
of the original URL is retained. The default is set to false.
of the original URL is retained.
returned: success
type: bool
region:
Expand Down
10 changes: 4 additions & 6 deletions plugins/modules/gcp_compute_url_map.py
Original file line number Diff line number Diff line change
Expand Up @@ -783,8 +783,7 @@
description:
- If set to true, any accompanying query portion of the original URL
is removed prior to redirecting the request. If set to false, the
query portion of the original URL is retained. The default is set
to false.
query portion of the original URL is retained.
required: false
default: 'false'
type: bool
Expand Down Expand Up @@ -1641,7 +1640,7 @@
description:
- If set to true, any accompanying query portion of the original URL is
removed prior to redirecting the request. If set to false, the query
portion of the original URL is retained. The default is set to false.
portion of the original URL is retained.
required: false
default: 'false'
type: bool
Expand Down Expand Up @@ -2529,8 +2528,7 @@
description:
- If set to true, any accompanying query portion of the original URL
is removed prior to redirecting the request. If set to false, the
query portion of the original URL is retained. The default is set
to false.
query portion of the original URL is retained.
returned: success
type: bool
routeRules:
Expand Down Expand Up @@ -3323,7 +3321,7 @@
description:
- If set to true, any accompanying query portion of the original URL is
removed prior to redirecting the request. If set to false, the query portion
of the original URL is retained. The default is set to false.
of the original URL is retained.
returned: success
type: bool
tests:
Expand Down
6 changes: 2 additions & 4 deletions plugins/modules/gcp_compute_url_map_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -811,8 +811,7 @@
description:
- If set to true, any accompanying query portion of the original
URL is removed prior to redirecting the request. If set to false,
the query portion of the original URL is retained. The default
is set to false.
the query portion of the original URL is retained.
returned: success
type: bool
routeRules:
Expand Down Expand Up @@ -1625,8 +1624,7 @@
description:
- If set to true, any accompanying query portion of the original URL
is removed prior to redirecting the request. If set to false, the
query portion of the original URL is retained. The default is set
to false.
query portion of the original URL is retained.
returned: success
type: bool
tests:
Expand Down

0 comments on commit 9bfffd5

Please sign in to comment.