NTP ansible module #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerry-meyer
reviewed
Aug 12, 2022
kerry-meyer
reviewed
Aug 12, 2022
kerry-meyer
reviewed
Aug 15, 2022
kerry-meyer
reviewed
Aug 16, 2022
kerry-meyer
reviewed
Aug 16, 2022
kerry-meyer
reviewed
Aug 16, 2022
kerry-meyer
reviewed
Aug 16, 2022
kerry-meyer
reviewed
Aug 17, 2022
| requests = [] | ||
|
|
||
| enable_auth_config = configs.get('enable_ntp_auth', None) | ||
| if enable_auth_config is not None: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
I have finished checking all changed files and have posted all of my comments for the change set. The code structure looks great! Most of my comments are related to efficiency and performance considerations. |
kerry-meyer
reviewed
Aug 17, 2022
kerry-meyer
reviewed
Aug 17, 2022
kerry-meyer
approved these changes
Aug 31, 2022
|
All currently posted changes and test results look good. Approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add NTP module
ISSUE TYPE
COMPONENT NAME
sonic_ntp
ADDITIONAL INFORMATION
Regression test log:
ntp_regression_test.log
Regression test result:
regression-2022-08-31-11-01-14.html.pdf
Negative testing log for server/ntp_keys parameter deleted:
delete_server_key_parameter_negative_test.log
CLI verification show log:
ntp_cli_show.txt
SONIC DB verification show log:
ntp_db_show.txt