Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved aaa and users regression playbook failures and added stable-2.13 to test matrix #90

Merged
merged 18 commits into from
May 27, 2022
Merged

Resolved aaa and users regression playbook failures and added stable-2.13 to test matrix #90

merged 18 commits into from
May 27, 2022

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented May 26, 2022 •
edited
Loading

SUMMARY
  • I corrected the conditional statements in sonic_aaa and sonic_users facts that were causing the playbooks to fail.
  • For sonic_users, password is required and write only. Password cannot be modified. User must be deleted and recreated with new password. User must have role and password so deletion is only allowed at user level.
  • I added stable-2.13 to the sanity test matrix.

Fixes #73

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sonic_aaa

ADDITIONAL INFORMATION

aaa_output.log
regression-2022-05-26-09-48-15.html.pdf
users_output.log
users-regression-2022-05-27-12-12-29.html.pdf

Shade Talabi and others added 17 commits May 19, 2022 14:16
Updated encrypted password
4eb248d
Removed repetitive delete test case
4317fab
Resolved system playbook failures
97e9776
Merge branch '2.0_reg_fixes' of https://github.com/stalabi1/dellemc.e…
e0c0c09 
…nterprise_sonic into 2.0_reg_fixes
Added required execution-environment.yml
88f1fe7
@stalabi1
Merge branch 'ansible-collections:main' into 2.0_reg_fixes
685df4f
Resolved sanity error
a7b91bc
Merge branch '2.0_reg_fixes' of https://github.com/stalabi1/dellemc.e…
cc49a7c 
…nterprise_sonic into 2.0_reg_fixes
Resolved sanity error
a6c2b06
Resolved sanity test errors
4c6769f
Resolved port_breakout regression playbook failures against 4.x
4fc0e8a
Removed debugging prints
f437251
Reverting requirements.txt
8b54fdd
@stalabi1
Merge branch 'ansible-collections:main' into 2.0_reg_fixes
b3e0030
Added stable-2.13 to test matrix
a6d2a19
Merge branch '2.0_reg_fixes' of https://github.com/stalabi1/dellemc.e…
b5ed423 
…nterprise_sonic into 2.0_reg_fixes
Resolved aaa regression playbook failures
f82c0b9
@stalabi1 stalabi1 requested a review from kerry-meyer May 26, 2022 16:59
@stalabi1 stalabi1 changed the title Resolved aaa regression playbook failures and added stable-2.13 to test matrix Resolved aaa and users regression playbook failures and added stable-2.13 to test matrix May 27, 2022
kerry-meyer
kerry-meyer approved these changes May 27, 2022
View reviewed changes
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes and test results look good.

Approved.

@kerry-meyer kerry-meyer merged commit 14f629e into ansible-collections:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerry-meyer kerry-meyer kerry-meyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Action required: Add stable-2.13 to the test matrix
2 participants
@stalabi1 @kerry-meyer