Adding switching-mode functionality to the system module #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overriding and replacing don't make sense for this feature since it is a binary store-and-forward/cut-through option.
Added showcase for the replaced function with switching-mode
Updating the fact gathering to handle the case switching-mode has not been configured and the REST response is empty
stalabi1
reviewed
Jan 24, 2025
Removed unnecessary files and simplified system module regression tests
Only one of the conditional statements removed empty values from want. Moving the remove empties function to before the conditional. This only affects enabling the conditional logic and has not downstream functional changes.
…d infra files. Using Arun's recommendations for the infra file restructuring.
Making 2 newlines between test cases as standard and 1 space between sections within test case.
…onality. Removing auto-breakout stub that didn't have a corresponding pre-config or delete in deleted_02.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding the switching-mode feature to the system module with unit tests and regression tests.
ISSUE TYPE
COMPONENT NAME
switching-mode: system
OUTPUT
Switching-mode-regression-test-results_PR_review-Shade_comments.pdf
Regression_Switching-Mode_Sonic-System_PR_review-Shade_comments.log
ADDITIONAL INFORMATION
The REST endpoint for this feature is an empty response by default. This means the device is set to the default STORE_THEN_FORWARD.
When one sets the switching-mode to CUT_THROUGH at least once the REST endpoint will start returning the expected responses with the correct states, even when set to the default STORE_THEN_FORWARD.
The ability to set the CUT_THROUGH mode is not available on all platforms.
If you try to set that mode on an unsupported device you will receive an error message.
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration