Fix l3_interfaces regression failures due to IPv6 default "dad" configuration #428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Changes made in SONiC for handling of default l3_interfaces IPv6 "dad" (duplicate address detection) configuration
have caused breakage in the enterprise_sonic l3_interfaces resource module. This breakage is evident in recent
regression test runs. It is caused by the fact that SONiC now represents a "deleted" IPv6 "dad" configuration as
an "active" (present) configuration with a value of "DISABLE". The previous SONiC handling for this attribute,
which represented deleted IPv6 "dad" configuration as "null" was consistent with handling of almost all
configuration options in SONiC and was compatible with our Ansible handling.
The new behavior caused failures in idempotency handling, resulting in sending of requests for configuration that was already present in cases where the configuration contained deleted IPv6 "dad" configuration.
The change set proposed in this PR enables correct Ansible configuration behavior for the cases that were causing failures by selectively filtering out IPv6 "dad" configuration that is not actually present.
GitHub Issues
List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".
ISSUE TYPE
COMPONENT NAME
l3_interfaces
OUTPUT
l3_interfaces_dad_default_cfg_PR_regression-2024-08-10-20-03-17.zip
ADDITIONAL INFORMATION
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
I re-ran the failing regression test section for l3_interfaces to verify that it passes with the proposed changes.