Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mgmt servers module #412

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented Jul 3, 2024

SUMMARY

I added the mgmt servers module.

Please see model PR.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_mgmt_servers

OUTPUT

regression-2024-07-22-09-57-29.html.pdf
diff_output.log
facts_gathering.log
check_merge.log
check_delete.log

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • [] I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.

@stalabi1 stalabi1 added the new_resource_module This pull request adds a new resource module label Jul 3, 2024
@stalabi1 stalabi1 added this to the v2.5.0 milestone Jul 3, 2024
@stalabi1 stalabi1 requested a review from kerry-meyer as a code owner July 3, 2024 19:01
@kerry-meyer
Copy link
Collaborator

kerry-meyer commented Jul 30, 2024

Note: A Unit Test code coverage proportion of 78% is being allowed for the 'config' file in this change set for the following reason:

~20% of the code lines in the 'config' file are provided for implementation of 'check' mode functionality. Because this does not generate requests to the device, our current UT framework can not be used for validation of this code. All of the other added code is well covered by the added UT test cases, so the current UT coverage level for this resource module is sufficient.

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code logic, the corresponding test cases, and test results all look good.

I am posting only a few very minor requests for changes.

plugins/modules/sonic_mgmt_servers.py Show resolved Hide resolved
plugins/modules/sonic_mgmt_servers.py Show resolved Hide resolved
plugins/modules/sonic_mgmt_servers.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the current code submitted for this PR and the corresponding test results look good.

Thank you for implementing the management servers resource module.

Approved.

@kerry-meyer kerry-meyer merged commit 13fc753 into ansible-collections:main Aug 6, 2024
15 checks passed
@stalabi1 stalabi1 deleted the mgmt_servers branch September 4, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new_resource_module This pull request adds a new resource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants