-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mgmt servers module #412
Conversation
plugins/module_utils/network/sonic/config/mgmt_servers/mgmt_servers.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/mgmt_servers/mgmt_servers.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/mgmt_servers/mgmt_servers.py
Outdated
Show resolved
Hide resolved
Note: A Unit Test code coverage proportion of 78% is being allowed for the 'config' file in this change set for the following reason: ~20% of the code lines in the 'config' file are provided for implementation of 'check' mode functionality. Because this does not generate requests to the device, our current UT framework can not be used for validation of this code. All of the other added code is well covered by the added UT test cases, so the current UT coverage level for this resource module is sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code logic, the corresponding test cases, and test results all look good.
I am posting only a few very minor requests for changes.
Co-authored-by: Kerry Meyer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the current code submitted for this PR and the corresponding test results look good.
Thank you for implementing the management servers resource module.
Approved.
SUMMARY
I added the mgmt servers module.
Please see model PR.
ISSUE TYPE
COMPONENT NAME
sonic_mgmt_servers
OUTPUT
regression-2024-07-22-09-57-29.html.pdf
diff_output.log
facts_gathering.log
check_merge.log
check_delete.log
Checklist: