Ansible support for Versatile hash feature

[ohu1]

SUMMARY

Ansible support for Versatile Hash feature

GitHub Issues

"N/A".

GitHub Issue #

ISSUE TYPE

N/A

COMPONENT NAME

sonic-system (Update existing module)

ADDITIONAL INFORMATION

N/A
`

Checklist:

• [ x] I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
• [x ] I have verified that new and existing unit tests pass locally with my changes
• [ x] I have not allowed coverage numbers to degenerate
• [x ] I have maintained at least 90% code coverage
• [ x] I have commented my code, particularly in hard-to-understand areas
• [x ] I have made corresponding changes to the documentation
• [x ] I have added tests that prove my fix is effective or that my feature works
• [ x] I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
• [ x] I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

How Has This Been Tested?

Regression test with updated testcases.

regression-2024-06-28-12-07-00.html.gz

[kerry-meyer]

Thank you for implementing Ansible support for the Versatile hash feature.

I have posted a few file and inline comments to address for this PR. In addition, please fix the UT and sanity errors that are flagged for this PR.

Note: You can pre-run the sanity tests (including UT) before pushing changes to the PR branch using the instructions at:

https://github.com/ansible-collections/dellemc.enterprise_sonic/wiki/Running-Unit-Tests-and-Coverage-Report-Generation

[ohu1]

attached new regression result: pass

[kerry-meyer]

Thank you for making the incremental changes to address the first pass review comments.

There are still some problems to address.

I have posted some specific comments for these.

An additional comment: Please pre-run the sanity tests using the instructions at "https://github.com/ansible-collections/dellemc.enterprise_sonic/wiki/Running-Unit-Tests-and-Coverage-Report-Generation" and fix any remaining sanity errors before pushing the new changes to this PR.

[kerry-meyer]

Thank you for making the additional changes to get rid of the "empty" value display in facts gathering. The regression result output looks fine now.

There are still some sanity checks failing.

I am posting comment for one (a hyphen in a list line that is apparently causing YAML parsing problems.)

The first 3 of the following 4 errors are easy to find and fix:

ERROR: Found 4 pylint issue(s) which need to be resolved: ERROR: plugins/module_utils/network/sonic/config/system/system.py:62:8: undefined-variable: Undefined variable 'new_config' ERROR: plugins/module_utils/network/sonic/config/system/system.py:401:15: singleton-comparison: Comparison 'load_share_hash_algo != None' should be 'load_share_hash_algo is not None' ERROR: plugins/module_utils/network/sonic/config/system/system.py:465:23: trailing-whitespace: Trailing whitespace ERROR: plugins/module_utils/network/sonic/config/system/system.py:468:0: trailing-newlines: Trailing newlines

Please push changes to address the items described here and in the new comment.

[ohu1]

Thank you for making the additional changes to get rid of the "empty" value display in facts gathering. The regression result output looks fine now.

There are still some sanity checks failing.

I am posting comment for one (a hyphen in a list line that is apparently causing YAML parsing problems.)

The first 3 of the following 4 errors are easy to find and fix:

ERROR: Found 4 pylint issue(s) which need to be resolved: ERROR: plugins/module_utils/network/sonic/config/system/system.py:62:8: undefined-variable: Undefined variable 'new_config' ERROR: plugins/module_utils/network/sonic/config/system/system.py:401:15: singleton-comparison: Comparison 'load_share_hash_algo != None' should be 'load_share_hash_algo is not None' ERROR: plugins/module_utils/network/sonic/config/system/system.py:465:23: trailing-whitespace: Trailing whitespace ERROR: plugins/module_utils/network/sonic/config/system/system.py:468:0: trailing-newlines: Trailing newlines

Please push changes to address the items described here and in the new comment.

The above errors are fixed now.

[kerry-meyer]

All issues have been resolved, and sanity tests are passing with most recent change set.

Approved.