-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSPFv2_interfaces - Add Enterprise SONiC resource module #385
OSPFv2_interfaces - Add Enterprise SONiC resource module #385
Conversation
plugins/module_utils/network/sonic/facts/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/facts/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
@ArunSaravananBalachandran please review the latest changes, resolve any open comments that you feel have been adequately addressed, and review/approve this PR. |
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ospfv2_interfaces/ospfv2_interfaces.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Arun Saravanan Balachandran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The posted change set and corresponding test results look good.
Thank you very much for implementing the OSPFv2 "interfaces" resource module for the enterprise_sonic Ansible collection.
Approved.
SUMMARY
merged
,deleted
,overridden
andreplaced
states.GitHub Issues
List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".
ISSUE TYPE
COMPONENT NAME
OUTPUT
regression-2024-08-05-14-48-41.zip
ADDITIONAL INFORMATION
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration