-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AAA module #382
Update AAA module #382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed changes and corresponding test results look good.
Thank you for re-posting these changes to bring the AAA module into compliance with the intended SONiC functionality for AAA.
Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't finished reviewing this PR, but I'm posting my current comments so they can be addressed in parallel with adding support for the new AAA 'name-service' attributes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the 2.x branch sync is done, we can proceed with merging this revised AAA resource module.
I have finished checking the contents of this PR. All proposed changes and corresponding test results look good.
Thank you for providing this revised version of the AAA resource module to better fit the intent and current operation of the AAA feature in SONiC.
Approved.
SUMMARY
I updated the AAA module authentication implementation to support ordered authentication. This is a breaking change that was reverted in #269.
Please see model PR.
ISSUE TYPE
COMPONENT NAME
sonic_aaa
OUTPUT
regression-2024-07-23-14-56-54.html.pdf
diff_output.log
merge_aaa.yaml.txt
check_merged.log
delete_aaa_yaml.txt
check_delete.log
facts_gathering.log
Checklist: