Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AAA module #382

Merged
merged 16 commits into from
Aug 20, 2024
Merged

Update AAA module #382

merged 16 commits into from
Aug 20, 2024

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented May 16, 2024

SUMMARY

I updated the AAA module authentication implementation to support ordered authentication. This is a breaking change that was reverted in #269.

Please see model PR.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_aaa

OUTPUT

regression-2024-07-23-14-56-54.html.pdf
diff_output.log
merge_aaa.yaml.txt
check_merged.log
delete_aaa_yaml.txt
check_delete.log
facts_gathering.log

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

@stalabi1 stalabi1 marked this pull request as ready for review May 16, 2024 21:25
@stalabi1 stalabi1 requested a review from kerry-meyer as a code owner May 16, 2024 21:25
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes and corresponding test results look good.

Thank you for re-posting these changes to bring the AAA module into compliance with the intended SONiC functionality for AAA.

Approved.

@stalabi1 stalabi1 closed this Jun 11, 2024
@stalabi1 stalabi1 reopened this Jun 11, 2024
@stalabi1 stalabi1 added this to the v3.0.0 milestone Jun 12, 2024
@stalabi1 stalabi1 changed the title Update AAA module authentication implementation Update AAA module Jun 19, 2024
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finished reviewing this PR, but I'm posting my current comments so they can be addressed in parallel with adding support for the new AAA 'name-service' attributes.

plugins/module_utils/network/sonic/argspec/aaa/aaa.py Outdated Show resolved Hide resolved
plugins/module_utils/network/sonic/facts/aaa/aaa.py Outdated Show resolved Hide resolved
plugins/module_utils/network/sonic/facts/aaa/aaa.py Outdated Show resolved Hide resolved
plugins/module_utils/network/sonic/facts/aaa/aaa.py Outdated Show resolved Hide resolved
plugins/module_utils/network/sonic/facts/aaa/aaa.py Outdated Show resolved Hide resolved
plugins/module_utils/network/sonic/config/aaa/aaa.py Outdated Show resolved Hide resolved
plugins/module_utils/network/sonic/config/aaa/aaa.py Outdated Show resolved Hide resolved
@mingjunzhang2019 mingjunzhang2019 self-requested a review July 23, 2024 20:35
@mingjunzhang2019 mingjunzhang2019 self-requested a review July 24, 2024 16:23
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the 2.x branch sync is done, we can proceed with merging this revised AAA resource module.

I have finished checking the contents of this PR. All proposed changes and corresponding test results look good.

Thank you for providing this revised version of the AAA resource module to better fit the intent and current operation of the AAA feature in SONiC.

Approved.

@kerry-meyer kerry-meyer merged commit c792f81 into ansible-collections:main Aug 20, 2024
15 checks passed
@stalabi1 stalabi1 deleted the aaa branch September 4, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants