-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RoCE module #363
Add RoCE module #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, a few comments
@xhan-dell Thanks for the comments. The PR isn't ready but I just wanted to create a draft for Kerry to easily see my code as we are debugging the reboot issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your hard work to implement this difficult new configuration case.
The proposed code, new tests, and test results look good.
My only comments are for minor wording changes in documentation and comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these incremental revisions.
All issues are resolved now. The current proposed code, test coverage, and test results look good.
Approved.
SUMMARY
I added the RoCE module.
ISSUE TYPE
COMPONENT NAME
sonic_roce
OUTPUT
regression-2024-05-15-15-22-53.html.pdf
regression-2024-05-15-15-08-43.html.pdf
diff_output.log
facts_gathering.log
show_running.txt
Checklist: