Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRRP - Add Enterprise SONiC resource module #353

Merged
merged 19 commits into from
Jul 28, 2024

Conversation

santhosh-kt
Copy link
Collaborator

@santhosh-kt santhosh-kt commented Mar 13, 2024

SUMMARY
  • Add Enterprise SONiC 'VRRP' resource module:
    • Provide data definitions in 'argspec'.
    • Implement 'facts' to gather facts for the module.
    • Implement 'config' to apply configurations for merged , deleted, overridden and replaced states.
  • Define regression test cases to verify correct functionality of vrrp resource module.
  • Define unit test cases to verify correct functionality of vrrp resource module.
GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".

GitHub Issue #
N/A
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • sonic_vrrp
Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues

  • I have verified that new and existing unit tests pass locally with my changes

  • I have not allowed coverage numbers to degenerate

  • I have maintained at least 90% code coverage

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation

  • I have added tests that prove my fix is effective or that my feature works

  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.

  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

  • Regression test detailed log along with check_mode:
    regression-2024-07-23-11-38-41.zip

@santhosh-kt santhosh-kt added the new_resource_module This pull request adds a new resource module label Mar 13, 2024
@santhosh-kt
Copy link
Collaborator Author

Addressed default testcases for replaced and overridden. Please review.

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing the Ansible support for the VRRP resource module.

Approved.

@kerry-meyer kerry-meyer merged commit b6152e5 into ansible-collections:main Jul 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new_resource_module This pull request adds a new resource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants