Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QoS scheduler module #343

Merged
merged 9 commits into from
May 1, 2024

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented Feb 23, 2024

SUMMARY

I added the QoS scheduler module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_qos_scheduler

OUTPUT

regression-2024-04-30-09-49-05.html.pdf
diff_output.log
facts_gathering.log

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.

@stalabi1 stalabi1 added the new_resource_module This pull request adds a new resource module label Feb 23, 2024
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code structure, new tests, and test results look good.

I have posted several comments, but most of them are minor and none require any big changes.

plugins/modules/sonic_qos_scheduler.py Outdated Show resolved Hide resolved
plugins/modules/sonic_qos_scheduler.py Show resolved Hide resolved
plugins/modules/sonic_qos_scheduler.py Outdated Show resolved Hide resolved
plugins/modules/sonic_qos_scheduler.py Outdated Show resolved Hide resolved
plugins/modules/sonic_qos_scheduler.py Outdated Show resolved Hide resolved
plugins/modules/sonic_qos_scheduler.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the final set of incremental changes.

The revised change set and all revised posted test results look good.

Approved.

@kerry-meyer kerry-meyer merged commit 4dc42d3 into ansible-collections:main May 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new_resource_module This pull request adds a new resource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants