-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QoS scheduler module #343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code structure, new tests, and test results look good.
I have posted several comments, but most of them are minor and none require any big changes.
plugins/module_utils/network/sonic/config/qos_scheduler/qos_scheduler.py
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/qos_scheduler/qos_scheduler.py
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/qos_scheduler/qos_scheduler.py
Show resolved
Hide resolved
plugins/module_utils/network/sonic/facts/qos_scheduler/qos_scheduler.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the final set of incremental changes.
The revised change set and all revised posted test results look good.
Approved.
SUMMARY
I added the QoS scheduler module.
ISSUE TYPE
COMPONENT NAME
sonic_qos_scheduler
OUTPUT
regression-2024-04-30-09-49-05.html.pdf
diff_output.log
facts_gathering.log
Checklist: