Add Enterprise SONIC LLDP Interface module

[m-nazeer]

SUMMARY

LLDP_INTERFACES Module implementation

GitHub Issues

N/A

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

sonic_lldp_interfaces

OUTPUT

Regression Test HTML report:
lldp_interface_log.zip

Checklist:

• I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
• I have verified that new and existing unit tests pass locally with my changes
• I have not allowed coverage numbers to degenerate
• I have maintained at least 90% code coverage
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
• I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

[kerry-meyer]

Closing and re-opening to clear "failure" for a missing fragment file.

[kerry-meyer]

To proceed with the code review for this resource module, please push changes for the following items:

• Re-sync your fork and branch to pull in updates from the "main" branch that are the probable cause of the flagged sanity failures for python3.10, 3.11, and 3.12 with the ansible-core "devel" version.
• Add Unit Test coverage. Use the UT implementation for the DHCP Relay module as an example of how to do this.

While you are working on the UT changes, we may go ahead with checking the changes that are in the current change set and posting an initial set of comments/questions (if any) for the current code. The PR can not be approved or merged, however, until the items described above have been completed.

[kerry-meyer]

I'm changing the state on this PR to "Request changes" to make it easier to see from the top level PR view.

Please address the comments posted by Mingjun Zhang either with the corresponding modifications in the change set or with response comments (for cases in which you would like clarification of the posted comment or do not agree with it).

[m-nazeer]

to

Hi Kerry. I am working on addressing the review comments for overridden and replaced logic. I will push the code changes once done

[kerry-meyer]

Thank you for making incremental changes to address Mingjun's review comments.

I have marked some of the "Issues" posted by Mingjun as "Resolved", but some are not, and I have posted a couple of additional comments.

• Please address the remaining open issues and post updated test results. In the posted test results, please format the summary output in a way that displays the 'before' and 'after' output without truncation. (Landscape, scaled as needed.)
• Please ensure that overridden/replaced test cases are causing deletion of some attributes within existing interface configurations. (This may already be the case, but it's not easy to see from the currently posted test results or by 'walking' the test list.)
• Please fix the UT failures and sanity failures.
• Please re-sync the PR branch to pick up changes from the 'main' branch and to resolve any conflicts that currently exist for shared files.

[kerry-meyer]

The code for the current proposed change set, the test case coverage, and all test results look good.

Approved.

Thank you for providing the LLDP Interfaces resource module for the Dell enterprise_sonic resource module collection.