-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated example playbooks to reflect module updates #102
Updated example playbooks to reflect module updates #102
Conversation
There is an example of "bfd: true" that needs to be updated in the "/playbooks/bgp_l3_fabric/group_vars/leaf.yaml" file. |
Although the sonic_bgp_as_paths "module" file has been updated to include the "permit" attribute as one of the "options", the "permit" attribute should also be added to the set of example playbook cases in that file (for the "merged" and "deleted" example cases). |
I have finished checking all of the changes for this change set and have no additional comments. |
The permit attribute already existed in the module file as an attribute option. The changes made are only to the "merged" and "deleted" example cases. I went back and updated one of the delete cases to delete the permit attribute. |
Thanks for providing the additional documentation updates and addressing all of the review comments. The current version of the change set looks good. Approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
SUMMARY
I updated the example playbooks to reflect module updates.
ISSUE TYPE
COMPONENT NAME
sonic_bgp_as_paths
bgp_l3_fabric
common_examples