Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated example playbooks to reflect module updates #102

Merged
merged 4 commits into from
Aug 11, 2022
Merged

Updated example playbooks to reflect module updates #102

merged 4 commits into from
Aug 11, 2022

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented Aug 3, 2022

SUMMARY

I updated the example playbooks to reflect module updates.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sonic_bgp_as_paths
bgp_l3_fabric
common_examples

@stalabi1 stalabi1 requested a review from kerry-meyer August 3, 2022 21:30
playbooks/common_examples/sonic_bgp.yaml Outdated Show resolved Hide resolved
playbooks/common_examples/sonic_bgp.yaml Outdated Show resolved Hide resolved
@kerry-meyer
Copy link
Collaborator

There is an example of "bfd: true" that needs to be updated in the "/playbooks/bgp_l3_fabric/group_vars/leaf.yaml" file.

@kerry-meyer
Copy link
Collaborator

Although the sonic_bgp_as_paths "module" file has been updated to include the "permit" attribute as one of the "options", the "permit" attribute should also be added to the set of example playbook cases in that file (for the "merged" and "deleted" example cases).

@kerry-meyer
Copy link
Collaborator

I have finished checking all of the changes for this change set and have no additional comments.

@stalabi1
Copy link
Collaborator Author

Although the sonic_bgp_as_paths "module" file has been updated to include the "permit" attribute as one of the "options", the "permit" attribute should also be added to the set of example playbook cases in that file (for the "merged" and "deleted" example cases).

The permit attribute already existed in the module file as an attribute option. The changes made are only to the "merged" and "deleted" example cases. I went back and updated one of the delete cases to delete the permit attribute.

@kerry-meyer

@kerry-meyer
Copy link
Collaborator

Thanks for providing the additional documentation updates and addressing all of the review comments.

The current version of the change set looks good.

Approved.

@kerry-meyer kerry-meyer reopened this Aug 11, 2022
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@kerry-meyer kerry-meyer merged commit a010d03 into ansible-collections:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants