Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for distutils.version being removed in Python 3.12 #597

Merged
merged 3 commits into from
Dec 28, 2021
Merged

Prepare for distutils.version being removed in Python 3.12 #597

merged 3 commits into from
Dec 28, 2021

Conversation

rockaut
Copy link
Contributor

@rockaut rockaut commented Dec 28, 2021

SUMMARY

Prepare for distutils.version being removed in Python 3.12

Relates to #585 and also #596

fixes #596
fixes #585

ISSUE TYPE
  • Bugfix Pull Request+

@rockaut rockaut marked this pull request as ready for review December 28, 2021 11:45
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #597 (779c803) into main (21ecab0) will decrease coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   76.68%   75.42%   -1.26%     
==========================================
  Files          22       23       +1     
  Lines        3020     3032      +12     
  Branches      779      779              
==========================================
- Hits         2316     2287      -29     
- Misses        461      492      +31     
- Partials      243      253      +10     
Impacted Files Coverage Δ
...ns/community/zabbix/plugins/modules/zabbix_user.py 78.80% <0.00%> (-10.14%) ⬇️
...unity/zabbix/plugins/modules/zabbix_globalmacro.py 65.25% <0.00%> (-6.78%) ⬇️
.../community/zabbix/plugins/modules/zabbix_screen.py 69.79% <0.00%> (-1.05%) ⬇️
...ommunity/zabbix/plugins/modules/zabbix_template.py 76.80% <0.00%> (-0.77%) ⬇️
...mmunity/zabbix/plugins/modules/zabbix_mediatype.py 86.95% <0.00%> (-0.73%) ⬇️
...ns/community/zabbix/plugins/modules/zabbix_host.py 82.00% <0.00%> (-0.63%) ⬇️
...s/community/zabbix/plugins/module_utils/helpers.py 75.36% <0.00%> (ø)
...s/community/zabbix/plugins/modules/zabbix_proxy.py 50.79% <0.00%> (ø)
.../community/zabbix/plugins/modules/zabbix_action.py 69.28% <0.00%> (ø)
...mmunity/zabbix/plugins/modules/zabbix_hostmacro.py 80.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7aab29...779c803. Read the comment docs.

@rockaut rockaut added bug Something isn't working enhancement New feature or request labels Dec 28, 2021
@rockaut rockaut added this to the 1.6.0 milestone Dec 28, 2021
@rockaut rockaut requested a review from D3DeFi December 28, 2021 11:51
Copy link
Contributor

@D3DeFi D3DeFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Probably even works? :)

@D3DeFi D3DeFi merged commit e875f9f into ansible-collections:main Dec 28, 2021
@rockaut rockaut deleted the fix_looseversion branch December 28, 2021 12:44
@rockaut
Copy link
Contributor Author

rockaut commented Dec 28, 2021

Looks good. Probably even works? :)

hopefully :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants