Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print details about the error message when the returned task result contains #2301

Conversation

Tomorrow9
Copy link
Collaborator

SUMMARY

Print details about the error message when the returned task result contains

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

Print details about the failed task if there are such message.

Before the change:

TASK [Customize Linux guest OS] **********************************************
task path: /home/worker/workspace/Pardus/ansible-vsphere-gos-validation/linux/guest_customization/linux_gosc_execution.yml:4
fatal: [localhost]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            ...
        }
    },
    "msg": "Customization of the guest operating system is not supported due to the given reason: ",
    "op": "customize_exist"
}

After the change:

TASK [Customize Linux guest OS] ************************************************
task path: /home/worker/workspace/Pardus/ansible-vsphere-gos-validation/linux/guest_customization/linux_gosc_execution.yml:4
fatal: [localhost]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            ...
        }
    },
    "msg": "Customization of the guest operating system is not supported due to the given reason: The guest OS 'Pardus (64-bit)' installed in the VM is not supported for customization. Refer to vCenter documentation for supported configurations: http://partnerweb.vmware.com/programs/guestOS/guest-os-customization-matrix.pdf",
    "op": "customize_exist"
}

Signed-off-by: dw035535 <[email protected]>
@mariolenz
Copy link
Collaborator

recheck

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find the time to test this, but the CI is happy and the code LGTM.

Thanks @Tomorrow9!

@mariolenz mariolenz added feature This issue/PR relates to a feature request mergeit labels Feb 6, 2025
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/3665425e2d3c4c38b6c7629c32ba3abe

✔️ ansible-tox-linters SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 5m 47s
✔️ ansible-galaxy-importer SUCCESS in 7m 47s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1fe4061 into ansible-collections:main Feb 6, 2025
13 checks passed
@Tomorrow9
Copy link
Collaborator Author

I didn't find the time to test this, but the CI is happy and the code LGTM.

Thanks @Tomorrow9!

Thanks for reviewing this.

@Tomorrow9 Tomorrow9 deleted the fix_gosc_error_msg branch February 7, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request mergeit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants