Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vmware_vsan_release_catalog module #1702

Merged
merged 4 commits into from
May 22, 2023
Merged

add vmware_vsan_release_catalog module #1702

merged 4 commits into from
May 22, 2023

Conversation

p-fruck
Copy link
Contributor

@p-fruck p-fruck commented Apr 5, 2023 •
edited by mariolenz
Loading

SUMMARY

This module allows to manually upload the vSAN release catalog to the vCenter which is useful for airgapped environments or other environments where the vCenter cannot directly connect to the VMware cloud service.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vmware_vsan_release_catalog

ADDITIONAL INFORMATION

Similar to #1675

@p-fruck
add vmware_vsan_release_catalog module
d14ade4 
This module allows to manually upload the vSAN release catalog
to the vCenter which is useful for airgapped environments or
other environments where the vCenter cannot directly connect to
the VMware cloud service.
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e79d82ad8aed4017bfa2818581c9c8f2

✔️ ansible-tox-linters SUCCESS in 8m 38s
✔️ build-ansible-collection SUCCESS in 9m 17s
❌ ansible-test-sanity-docker-devel FAILURE in 11m 34s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 10m 18s (non-voting)
⚠️ ansible-test-sanity-docker-stable-2.13 CANCELED
❌ ansible-test-sanity-docker-stable-2.14 FAILURE in 18m 41s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 33s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 51s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/de3b6023f3224692bf0f94b756ae3eb9

✔️ ansible-tox-linters SUCCESS in 8m 38s
✔️ build-ansible-collection SUCCESS in 9m 25s
⚠️ ansible-test-sanity-docker-devel CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-milestone CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-stable-2.13 CANCELED
❌ ansible-test-sanity-docker-stable-2.14 FAILURE in 7m 38s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 20s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 31s

@p-fruck
Copy link
Contributor Author

p-fruck commented Apr 25, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/909aecdd35764e00aa0492bde685a6f2

✔️ ansible-tox-linters SUCCESS in 9m 22s
✔️ build-ansible-collection SUCCESS in 10m 18s
❌ ansible-test-sanity-docker-devel FAILURE in 9m 24s (non-voting)
⚠️ ansible-test-sanity-docker-milestone CANCELED (non-voting)
❌ ansible-test-sanity-docker-stable-2.13 FAILURE in 9m 48s
⚠️ ansible-test-sanity-docker-stable-2.14 CANCELED
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 23s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 41s

@mariolenz
Copy link
Collaborator

@p-fruck I think that this is similar to #1675 and added this as an additional information to your PR. Please remove it again if I'm wrong.

mariolenz
mariolenz requested changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.6.0 is already released. Sorry :-(

plugins/modules/vmware_vsan_release_catalog.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/964e1287d0ed4c428961264ee81401a0

✔️ ansible-tox-linters SUCCESS in 8m 33s
✔️ build-ansible-collection SUCCESS in 9m 06s
⚠️ ansible-test-sanity-docker-devel CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-milestone CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-stable-2.13 CANCELED
❌ ansible-test-sanity-docker-stable-2.14 FAILURE in 9m 14s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 23s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 55s

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/adfcf64e8a384550ac12a8af73542468

✔️ ansible-tox-linters SUCCESS in 9m 12s
✔️ build-ansible-collection SUCCESS in 9m 20s
❌ ansible-test-sanity-docker-devel FAILURE in 9m 32s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 41s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 59s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 56s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 00s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable214 FAILURE in 16m 06s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 52s

@p-fruck
Copy link
Contributor Author

p-fruck commented May 18, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3d3b4d4762ce4329a3efcc594f460016

✔️ ansible-tox-linters SUCCESS in 9m 06s
✔️ build-ansible-collection SUCCESS in 9m 52s
❌ ansible-test-sanity-docker-devel FAILURE in 12m 21s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 34s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 43s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 57s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 09s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 FAILURE in 16m 22s
✔️ ansible-galaxy-importer SUCCESS in 3m 51s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/52062ab7faca43dea6e446dcbf2107ff

✔️ ansible-tox-linters SUCCESS in 8m 56s
✔️ build-ansible-collection SUCCESS in 9m 42s
❌ ansible-test-sanity-docker-devel FAILURE in 11m 10s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 37s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 08s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 58s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 08s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 20m 49s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 18m 22s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SUCCESS in 51m 55s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SUCCESS in 57m 37s
✔️ ansible-galaxy-importer SUCCESS in 3m 55s

mariolenz
mariolenz approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @p-fruck!

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/9859e51bc1454f389819c3e7b105e6ab

✔️ ansible-tox-linters SUCCESS in 8m 39s
✔️ build-ansible-collection SUCCESS in 7m 16s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 27s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 12s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 35s
✔️ ansible-galaxy-importer SUCCESS in 4m 32s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 60df9ac into ansible-collections:main May 22, 2023
@mariolenz mariolenz mentioned this pull request Jun 4, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 5, 2023
@mariolenz
meta/runtime.yml: Add missing modules (#1764)
b01f35d 
meta/runtime.yml: Add missing modules

SUMMARY
Add missing modules to meta/runtime.yml.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
runtime.yml
ADDITIONAL INFORMATION
#1675
#1702
#1704
#1736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
mergeit new_module New module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-fruck @mariolenz