vmware_guest_disk: add IDE disk support

[Tomorrow9]

Signed-off-by: Diane Wang [email protected]

SUMMARY

We want to use vmware_guest_disk module to add or reconfigure IDE disk on VM.

Fixes #1428
Fixes #1617

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_guest_disk

ADDITIONAL INFORMATION

- name: add new ide disk
   vmware_guest_disk:
        validate_certs: false
        hostname: "{{ vcenter_hostname }}"
        username: "{{ vcenter_username }}"
        password: "{{ vcenter_password }}"
        datacenter: "{{ datacenter_name }}"
        name: test_vm
        disk:
          - size_gb: 1
            type: thin
            datastore: Datastore1
            state: present
            controller_type: ide
            controller_number: 0
            unit_number: 1

[softwarefactory-project-zuul]

Build failed.

✔️ ansible-tox-linters SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 4m 18s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 19s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 02s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 40s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 24s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 27s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 17m 52s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable212 FAILURE in 19m 20s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 41s

[mariolenz]

recheck

[softwarefactory-project-zuul]

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 4m 32s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 03s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 25s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 26s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 25s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 45s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 18m 23s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 22m 53s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 48m 09s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 51m 51s
✔️ ansible-galaxy-importer SUCCESS in 3m 42s

[mariolenz]

Since you're working on vmware_guest_disk, do you think you could do something about some other issues about this module while you're at it?

Some of them might be easy (like #1617) and some a bit harder (like #1595), but it would be really great if you could do something about at least some of them.

[Tomorrow9]

Since you're working on vmware_guest_disk, do you think you could do something about some other issues about this module while you're at it?

Some of them might be easy (like #1617) and some a bit harder (like #1595), but it would be really great if you could do something about at least some of them.

It seems #1617 is easy to fix so I can fix it in this merge request. Thanks.

[softwarefactory-project-zuul]

Build failed.

❌ ansible-tox-linters FAILURE in 3m 52s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-sanity-docker-devel CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-milestone CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-stable-2.13 CANCELED
⚠️ ansible-test-sanity-docker-stable-2.14 CANCELED
⚠️ ansible-test-units-community-vmware-python38 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable212 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

[softwarefactory-project-zuul]

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 4m 06s
✔️ build-ansible-collection SUCCESS in 4m 18s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 04s (non-voting)
❌ ansible-test-sanity-docker-milestone POST_FAILURE in 8m 25s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 14s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 38s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 40s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 18m 57s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 20m 30s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 47m 48s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 57m 05s
✔️ ansible-galaxy-importer SUCCESS in 3m 35s

[mariolenz]

It seems #1617 is easy to fix so I can fix it in this merge request. Thanks.

Great! Thanks!

[mariolenz]

LGTM

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).

✔️ ansible-tox-linters SUCCESS in 4m 00s
✔️ build-ansible-collection SUCCESS in 3m 32s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 30s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 42s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 34s
✔️ ansible-galaxy-importer SUCCESS in 3m 37s