Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_host_vmnic_info: Fix issue with offline / disconnected / shut down hosts #1337

Merged
merged 2 commits into from
Jun 2, 2022
Merged

vmware_host_vmnic_info: Fix issue with offline / disconnected / shut down hosts #1337

merged 2 commits into from
Jun 2, 2022

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

vmware_host_vmnic_info breaks if a host is offline / disconnected / shut down.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_host_vmnic_info

ADDITIONAL INFORMATION

this comment

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ ansible-tox-linters SUCCESS in 5m 08s
✔️ build-ansible-collection SUCCESS in 4m 01s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 13s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 17s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 13s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 59s
✔️ ansible-test-units-community-vmware-python27 SUCCESS in 6m 47s
✔️ ansible-test-units-community-vmware-python36 SUCCESS in 4m 44s
✔️ ansible-test-units-community-vmware-python37 SUCCESS in 5m 03s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 10s
✔️ ansible-test-cloud-integration-vcenter7_only-python36-stable211 SUCCESS in 23m 39s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-python36-stable211 SUCCESS in 20m 51s
❌ ansible-test-cloud-integration-vcenter7_1esxi-python36-stable211_1_of_2 FAILURE in 1h 05m 47s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-python36-stable211_2_of_2 SUCCESS in 43m 43s
✔️ ansible-galaxy-importer SUCCESS in 4m 00s

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 3m 53s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 31s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 23s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 39s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 31s
✔️ ansible-test-units-community-vmware-python27 SUCCESS in 4m 39s
✔️ ansible-test-units-community-vmware-python36 SUCCESS in 4m 51s
✔️ ansible-test-units-community-vmware-python37 SUCCESS in 4m 40s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 02s
✔️ ansible-test-cloud-integration-vcenter7_only-python36-stable211 SUCCESS in 24m 20s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-python36-stable211 SUCCESS in 21m 42s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-python36-stable211_1_of_2 SUCCESS in 1h 08m 44s
❌ ansible-test-cloud-integration-vcenter7_1esxi-python36-stable211_2_of_2 FAILURE in 19m 14s
✔️ ansible-galaxy-importer SUCCESS in 4m 32s

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 4m 59s
✔️ build-ansible-collection SUCCESS in 5m 19s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 01s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 22s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 19s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 43s
✔️ ansible-test-units-community-vmware-python27 SUCCESS in 5m 03s
✔️ ansible-test-units-community-vmware-python36 SUCCESS in 5m 31s
✔️ ansible-test-units-community-vmware-python37 SUCCESS in 5m 36s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 55s
✔️ ansible-test-cloud-integration-vcenter7_only-python36-stable211 SUCCESS in 21m 32s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-python36-stable211 SUCCESS in 21m 08s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-python36-stable211_1_of_2 SUCCESS in 1h 10m 40s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-python36-stable211_2_of_2 SUCCESS in 45m 06s
✔️ ansible-galaxy-importer SUCCESS in 4m 24s

@mariolenz mariolenz changed the title [WIP] vmware_host_vmnic_info: Fix issue with offline / disconnected / shut down hosts vmware_host_vmnic_info: Fix issue with offline / disconnected / shut down hosts Jun 2, 2022
@mariolenz
Copy link
Collaborator Author

@anxstj Could you please test this PR? I hope it fixes the issue with vmware_host_vmnic_info you've mentioned in #318.

@anxstj
Copy link

anxstj commented Jun 2, 2022

Yes, it fixes the issue. Great.

This is the result I get if the host is powered-off:

"hosts_vmnics_info": {
            "test-esx0103.test01.dev": {
                "all": [
                    "vmnic0",
                    "vmnic1",
                    "vmnic2",
                    "vmnic3"
                ],
                "available": [
                    "vmnic2",
                    "vmnic3"
                ],
                "dvswitch": {
                    "dvs.test": [
                        "vmnic0",
                        "vmnic1"
                    ]
                },
                "num_vmnics": 4,
                "used": [
                    "vmnic0",
                    "vmnic1"
                ],
                "vmnic_details": [
                    {
                        "actual_duplex": "Full Duplex",
                        "actual_speed": 10000,
                        "adapter": "VMware Inc. vmxnet3 Virtual Ethernet Controller",
                        "configured_duplex": "Full Duplex",
                        "configured_speed": 10000,
                        "device": "vmnic0",
                        "driver": "nvmxnet3",
                        "lldp_info": "N/A",
                        "location": "0000:0b:00.0",
                        "mac": "00:50:56:bb:ca:fd",
                        "status": "Connected"
                    },
                    {
                        "actual_duplex": "Full Duplex",
                        "actual_speed": 10000,
                        "adapter": "VMware Inc. vmxnet3 Virtual Ethernet Controller",
                        "configured_duplex": "Full Duplex",
                        "configured_speed": 10000,
                        "device": "vmnic1",
                        "driver": "nvmxnet3",
                        "lldp_info": "N/A",
                        "location": "0000:13:00.0",
                        "mac": "00:50:56:bb:c2:32",
                        "status": "Connected"
                    },
                    {
                        "actual_duplex": "N/A",
                        "actual_speed": "N/A",
                        "adapter": "VMware Inc. vmxnet3 Virtual Ethernet Controller",
                        "configured_duplex": "Auto negotiate",
                        "configured_speed": "Auto negotiate",
                        "device": "vmnic2",
                        "driver": "nvmxnet3",
                        "lldp_info": "N/A",
                        "location": "0000:1b:00.0",
                        "mac": "00:50:56:bb:16:a2",
                        "status": "Disconnected"
                    },
                    {
                        "actual_duplex": "N/A",
                        "actual_speed": "N/A",
                        "adapter": "VMware Inc. vmxnet3 Virtual Ethernet Controller",
                        "configured_duplex": "Auto negotiate",
                        "configured_speed": "Auto negotiate",
                        "device": "vmnic3",
                        "driver": "nvmxnet3",
                        "lldp_info": "N/A",
                        "location": "0000:04:00.0",
                        "mac": "00:50:56:bb:e4:0d",
                        "status": "Disconnected"
                    }
                ],
                "vswitch": {}
            }
        }

@mariolenz
Copy link
Collaborator Author

Yes, it fixes the issue.

Good news, thanks for testing @anxstj!

@mariolenz mariolenz added bug This issue/PR relates to a bug integration tests/integration owner_pr PR created by owner/maintainer mergeit labels Jun 2, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

✔️ ansible-tox-linters SUCCESS in 4m 27s
✔️ build-ansible-collection SUCCESS in 4m 27s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 51s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 41s
✔️ ansible-galaxy-importer SUCCESS in 3m 53s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a39d1af into ansible-collections:main Jun 2, 2022
@mariolenz mariolenz deleted the vmware_host_vmnic_info_disconnected branch June 2, 2022 15:28
mariolenz added a commit to mariolenz/community.vmware that referenced this pull request Jun 6, 2022
@mariolenz
Backport PR ansible-collections#1337 to stable-1
cccd235
@mariolenz mariolenz mentioned this pull request Jun 6, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 7, 2022
@mariolenz
Backport PR #1337 to stable-1 (#1345)
5bb4784 
Backport PR #1337 to stable-1

SUMMARY
Backport PR #1337 to stable-1.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
vmware_host_vmnic_info
ADDITIONAL INFORMATION
@slauger slauger mentioned this pull request Jun 18, 2022
Closed
1 task
@slauger slauger mentioned this pull request Oct 11, 2022
Closed
1 task
@slauger slauger mentioned this pull request Oct 24, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug integration tests/integration mergeit owner_pr PR created by owner/maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariolenz @anxstj