Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role and playbooks to install sops, add EE tests, show how to use in EE #98

Merged
merged 24 commits into from
Dec 2, 2022

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Apr 15, 2022

SUMMARY

Try to make this collection EE ready, with tests.

Fixes #30.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

collection

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #98 (3b5ee51) into main (b3a4ebb) will increase coverage by 0.34%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   66.11%   66.46%   +0.34%     
==========================================
  Files          11       12       +1     
  Lines         971      990      +19     
  Branches      220      220              
==========================================
+ Hits          642      658      +16     
- Misses        249      252       +3     
  Partials       80       80              
Flag Coverage Δ
integration 65.36% <84.21%> (+0.37%) ⬆️
sanity 23.43% <73.68%> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/filter/_latest_version.py 84.21% <84.21%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixfontein
Copy link
Collaborator Author

Ok, after talking with some folks at yesterday's contributor summit, I think there will be no way to automatically make sure that sops is installed in EEs (except if there are regular system packages for sops). That's not the case or Debian, RHEL, and Alpine (except edge), for example. But what we can do is provide a sops installation role (planned anyway in #30), a playbook that installs sops on localhost, and provide instructions for users that they should run that playbook in the POST step for the EE build (similar to https://github.com/ansible-collections/community.sops/pull/98/files#diff-2136994feda0d08499dec5d6120a13cf594c3ab2f28f61d0ed17038f74417faaR9).

I'll try to work on that next.

@github-actions
Copy link

github-actions bot commented Oct 19, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.sops/branch/main

@felixfontein felixfontein changed the title [WIP] Try to make EE ready [WIP] Add role and playbooks to install sops, add EE tests, show how to use in EE Oct 19, 2022
@felixfontein felixfontein changed the title [WIP] Add role and playbooks to install sops, add EE tests, show how to use in EE Add role and playbooks to install sops, add EE tests, show how to use in EE Oct 20, 2022
@felixfontein
Copy link
Collaborator Author

I'm not really happy about having the filter plugin in this collection, since it's really unrelated to it, but I still prefer that over adding a dependency to another collection (like community.general) just to be able to sort by version.

Copy link

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are my (somewhat nitpicky) comments about the role. It looks pretty good to me.

.github/workflows/ee.yml Outdated Show resolved Hide resolved
roles/install/tasks/main.yml Outdated Show resolved Hide resolved
roles/install/vars/OS-RedHat.yml Outdated Show resolved Hide resolved
roles/install/tasks/main.yml Outdated Show resolved Hide resolved
roles/install/tasks/main.yml Show resolved Hide resolved
roles/install/tasks/detect_source.yml Outdated Show resolved Hide resolved
plugins/filter/latest_version.py Outdated Show resolved Hide resolved
@felixfontein felixfontein requested a review from endorama October 20, 2022 18:38
@felixfontein
Copy link
Collaborator Author

(I've uploaded the docs for the current version of this PR to https://ansible.fontein.de/collections/community/sops/)

@felixfontein
Copy link
Collaborator Author

I think this is really ready now. Also you can see the docs on the automatically built PR docsite: https://ansible-collections.github.io/community.sops/pr/98/

Copy link
Contributor

@kristianheljas kristianheljas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite clueless about testing so I was only able to review the roles.

playbooks/install_localhost.yml Show resolved Hide resolved
docs/docsite/rst/guide.rst Outdated Show resolved Hide resolved
roles/_install_age/tasks/main.yml Show resolved Hide resolved
roles/_install_age/tasks/main.yml Show resolved Hide resolved
@felixfontein
Copy link
Collaborator Author

I'm currently planning of merge this (and release a new version) by the end of this week. If someone wants to take another look, get something changed, or needs more time, please ping me or write that here before than :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install-sops role
4 participants