-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add role and playbooks to install sops, add EE tests, show how to use in EE #98
Conversation
Codecov Report
@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 66.11% 66.46% +0.34%
==========================================
Files 11 12 +1
Lines 971 990 +19
Branches 220 220
==========================================
+ Hits 642 658 +16
- Misses 249 252 +3
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Ok, after talking with some folks at yesterday's contributor summit, I think there will be no way to automatically make sure that sops is installed in EEs (except if there are regular system packages for sops). That's not the case or Debian, RHEL, and Alpine (except I'll try to work on that next. |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
I'm not really happy about having the filter plugin in this collection, since it's really unrelated to it, but I still prefer that over adding a dependency to another collection (like community.general) just to be able to sort by version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are my (somewhat nitpicky) comments about the role. It looks pretty good to me.
(I've uploaded the docs for the current version of this PR to https://ansible.fontein.de/collections/community/sops/) |
c23c245
to
d356717
Compare
I think this is really ready now. Also you can see the docs on the automatically built PR docsite: https://ansible-collections.github.io/community.sops/pr/98/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm quite clueless about testing so I was only able to review the roles.
I'm currently planning of merge this (and release a new version) by the end of this week. If someone wants to take another look, get something changed, or needs more time, please ping me or write that here before than :) |
SUMMARY
Try to make this collection EE ready, with tests.
Fixes #30.
ISSUE TYPE
COMPONENT NAME
collection