Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #284: Implement 'interface wireless access-list' and 'interface wireless connect-list' #340

Conversation

derdeagle
Copy link
Contributor

SUMMARY

Fixes #284: Implement 'interface wireless access-list' and 'interface wireless connect-list'

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • _api_data.py
  • api_info.py
  • api_modify.py
ADDITIONAL INFORMATION

I couldn't come up with primary keys for the paths. I myself don't have a use-case for this but all the tests I did locally worked fine.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.63%. Comparing base (11454b8) to head (c81e75c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   84.63%   84.63%           
=======================================
  Files          33       33           
  Lines        4112     4112           
  Branches      879      879           
=======================================
  Hits         3480     3480           
  Misses        452      452           
  Partials      180      180           
Flag Coverage Δ
integration 66.27% <ø> (ø)
sanity 21.56% <ø> (ø)
units 84.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 24, 2025

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

…ist' and 'interface wireless connect-list'

Add changelog fragment
@derdeagle derdeagle force-pushed the add-interface-wireless-access-and-connect-list branch from 5d624f0 to c81e75c Compare January 24, 2025 07:20
@felixfontein felixfontein merged commit 85d24d1 into ansible-collections:main Jan 24, 2025
30 checks passed
@felixfontein
Copy link
Collaborator

@derdeagle thanks for your contribution!

@derdeagle derdeagle deleted the add-interface-wireless-access-and-connect-list branch January 24, 2025 20:56
@derdeagle
Copy link
Contributor Author

My pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path interface wireless connect-list and access-list missing
2 participants