-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #609 Publication with columns #763
Fixes #609 Publication with columns #763
Conversation
I can't start integration test locally - so it is not finished. I'll need some help with that. I'm getting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a changelog fragment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kacperk hello, thanks for the PR
tests/integration/targets/postgresql_publication/tasks/postgresql_publication_initial.yml
Show resolved
Hide resolved
just mark this PR as draft here and push: you'll get the result of the tests here |
@Andersson007 I've manage to run the tests and I've added more of them. I think the PR is ready now. |
…stgres 15 or newer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kacperk if you press Commit suggestion
in all my suggestions, it'll probably fix the failed tests
changelogs/fragments/763-add-publication-with-specific-columns.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/postgresql_publication/tasks/postgresql_publication_initial.yml
Show resolved
Hide resolved
tests/integration/targets/postgresql_publication/tasks/postgresql_publication_initial.yml
Show resolved
Hide resolved
tests/integration/targets/postgresql_publication/tasks/postgresql_publication_initial.yml
Show resolved
Hide resolved
tests/integration/targets/postgresql_publication/tasks/postgresql_publication_initial.yml
Show resolved
Hide resolved
tests/integration/targets/postgresql_publication/tasks/postgresql_publication_initial.yml
Show resolved
Hide resolved
tests/integration/targets/postgresql_publication/tasks/postgresql_publication_initial.yml
Show resolved
Hide resolved
tests/integration/targets/postgresql_publication/tasks/postgresql_publication_initial.yml
Show resolved
Hide resolved
tests/integration/targets/postgresql_publication/tasks/postgresql_publication_initial.yml
Show resolved
Hide resolved
tests/integration/targets/postgresql_publication/tasks/postgresql_publication_initial.yml
Show resolved
Hide resolved
Co-authored-by: Andrew Klychkov <[email protected]>
@kacperk I pinged other folks to take a look, if no feedback, I'll take a final look as soon as possible but earliest on Monday, thanks |
@kacperk thanks for the contribution! Great module expansion!
|
SUMMARY
Fixes #609
Add possibility of creating publication with only specific columns
ISSUE TYPE
COMPONENT NAME
postgresql_publication
ADDITIONAL INFORMATION