Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #609 Publication with columns #763

Merged

Conversation

kacperk
Copy link
Contributor

@kacperk kacperk commented Nov 4, 2024

SUMMARY

Fixes #609

Add possibility of creating publication with only specific columns

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

postgresql_publication

ADDITIONAL INFORMATION
    postgresql_publication:
      name: '{{ test_pub }}'
      columns:
        users:
          - user_id
          - email
        some_other_table_with_al_columns: []

@kacperk
Copy link
Contributor Author

kacperk commented Nov 4, 2024

I can't start integration test locally - so it is not finished. I'll need some help with that.

I'm getting ERROR! couldn't resolve module/action 'locale_gen'. when trying to run it.

@kacperk kacperk marked this pull request as ready for review November 5, 2024 09:05
@kacperk kacperk changed the title Publication with columns Fixes #609 Publication with columns Nov 5, 2024
Copy link
Collaborator

@hunleyd hunleyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a changelog fragment

plugins/modules/postgresql_publication.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kacperk hello, thanks for the PR

plugins/modules/postgresql_publication.py Show resolved Hide resolved
plugins/modules/postgresql_publication.py Outdated Show resolved Hide resolved
plugins/modules/postgresql_publication.py Outdated Show resolved Hide resolved
plugins/modules/postgresql_publication.py Outdated Show resolved Hide resolved
plugins/modules/postgresql_publication.py Outdated Show resolved Hide resolved
plugins/modules/postgresql_publication.py Outdated Show resolved Hide resolved
@Andersson007
Copy link
Collaborator

I can't start integration test locally - so it is not finished. I'll need some help with that.

I'm getting ERROR! couldn't resolve module/action 'locale_gen'. when trying to run it.

just mark this PR as draft here and push: you'll get the result of the tests here

@kacperk
Copy link
Contributor Author

kacperk commented Nov 7, 2024

@Andersson007 I've manage to run the tests and I've added more of them. I think the PR is ready now.

Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kacperk if you press Commit suggestion in all my suggestions, it'll probably fix the failed tests

@Andersson007
Copy link
Collaborator

@kacperk I pinged other folks to take a look, if no feedback, I'll take a final look as soon as possible but earliest on Monday, thanks

@Andersson007 Andersson007 merged commit 2a80a1a into ansible-collections:main Nov 11, 2024
29 checks passed
@Andersson007
Copy link
Collaborator

@kacperk thanks for the contribution! Great module expansion!
@hunleyd thanks for reviewing!

@kacperk

  • feel free to add yourself to the authors: field in the module DOCUMENTATION section in another PR
  • hope you'll be around if someone submits related issues
  • we have a forum group and a channel on Matrix, you're welcome to join, see the communication guide for details. There's not a lot of messages coming from them, mostly asking for help with releasing and announcements

@kacperk kacperk deleted the publication_with_columns branch November 11, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publication creation doesn't support specifying columns for published table
3 participants