Support grants and revokes on foreign tables

[nickgsc]

SUMMARY

Fixes #724

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

postgresql_privs

ADDITIONAL INFORMATION

See #724 for reproduction steps and the nature of the issue. The fix is straight-forward, we simply need to include relkind='f' in our acls check in order for foreign tables to be considered by the privs module

[Andersson007]

@nickgsc hello, thanks for the PR! LGTM, a rare case when everything necessary like a changelog fragment and tests is in place, well done!

Folks, maybe we should also add to the DOCUMENTATION section that this kind of tables is supported since 3.6.0?

[hunleyd]

Folks, maybe we should also add to the DOCUMENTATION section that this kind of tables is supported since 3.6.0?

probably wouldn't hurt @Andersson007

(hence approving but not merging)

[nickgsc]

I have one other issue to report (related to the postgresql_subscription module) with a companion PR to fix it that I just haven't gotten a chance to submit yet. Hoping to do that today. So if y'all want to wait to cut a new release for that, we could bundle them up.

[Andersson007]

I have one other issue to report (related to the postgresql_subscription module) with a companion PR to fix it that I just haven't gotten a chance to submit yet. Hoping to do that today. So if y'all want to wait to cut a new release for that, we could bundle them up.

Sure, please update the docs and we'll merge this PR, then we'll wait for the subscription PR - we have no problem with releasing not as often as we should;)

[nickgsc]

Sounds good. For reference, the other issue is #726 with the fix PR in #727

I'll push updates to the docs on this PR today

[Andersson007]

@nickgsc thanks for the contribution! @hunleyd thanks for reviewing!