-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix connect_params being ignored on postgresql_privs #451
Fix connect_params being ignored on postgresql_privs #451
Conversation
655ce55
to
edd7c12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@JohnAtOlo thanks for the contribution! Our bot failed to backport the patch to |
@Andersson007 the link you have there isn't loading for me. |
@JohnAtOlo Oh, sorry, copy-pasted something wrong, here it is https://docs.ansible.com/ansible/devel/community/development_process.html#backporting-merged-prs-in-ansible-core |
(cherry picked from commit bbb3257)
Backport PR up at #455 @Andersson007 |
SUMMARY
Fixes #450
Where connect_params were ignored for community.postgresql.postgresql_privs
ISSUE TYPE
COMPONENT NAME
postgresql_privs
ADDITIONAL INFORMATION
Previous connect_params were ignored. A helper method used in postgresql_user took care of this and other checking which was being done here, including unix socket check.
The end result is connect_params being properly honored now.
connect_params with:
Before: (fails with cert error, same cert error I get if I leave out connect_params entirely)
After: (uses the connect_params successfuly, like
community.postgresql.postgresql_membership
andcommunity.postgresql.postgresql_user
do)