Add clarification for RDS with regard to (NO)SUPERUSER attributes #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty.postgresql * 'main' of https://github.com/ansible-collections/community.postgresql: Release 2.1.4 commit add new docsite links feature (ansible-collections#248)
…ty.postgresql * 'main' of https://github.com/ansible-collections/community.postgresql: Remove changelog fragment for doc change. Update changelog to reflect doc changes for postgresql_owner.py Change documentation to be more clear that the changes take place for the entire cluster/instance rather than just a single DB. Fix `nonetype` by adding `ensure_required_libs` to `get_conn_params` in postgres.py (ansible-collections#253) Update unit tests (ansible-collections#258) docs: announce the new matrix pg room (ansible-collections#254)
hunleyd
approved these changes
May 7, 2022
Andersson007
approved these changes
May 9, 2022
Backport to stable-1: 💚 backport PR created✅ Backport PR branch: Backported as #262 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 9, 2022
* Update README.md to remove Ansible 2.9 & 2.10 * Update version.py comment to remove references to Ansible version 2.9 & 2.10 * Update changelog * Updated to include feedback from @Andersson007i * Add note concerning RDS and the `(NO)SUPERUSER` attribute. (cherry picked from commit 05eda3a)
|
@jchancojr thank you for the contribution! @hunleyd thanks for reviewing! |
Andersson007
pushed a commit
that referenced
this pull request
May 9, 2022
…) (#262) * Update README.md to remove Ansible 2.9 & 2.10 * Update version.py comment to remove references to Ansible version 2.9 & 2.10 * Update changelog * Updated to include feedback from @Andersson007i * Add note concerning RDS and the `(NO)SUPERUSER` attribute. (cherry picked from commit 05eda3a) Co-authored-by: Jim Chanco Jr <[email protected]>
jchancojr
added a commit
to jchancojr/community.postgresql
that referenced
this pull request
Jun 2, 2022
…ty.postgresql * 'main' of https://github.com/ansible-collections/community.postgresql: Release 2.1.5 commit (ansible-collections#275) docs: add PSF license file (ansible-collections#272) Issue 240 (ansible-collections#260) Add new maintainer and contributors (ansible-collections#264) Fix README (ansible-collections#263) Add clarification for RDS with regard to (NO)SUPERUSER attributes (ansible-collections#261)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Explain that attempting to run playbooks with
role_attr_flagscontaining(NO)SUPERUSERwill not provide idempotency due to how RDS hides SUPERUSER.ISSUE TYPE
COMPONENT NAME
postgresql_user.py
ADDITIONAL INFORMATION
Fixes #96