Remove onyx from old collection for merging with new one

[samerd]

SUMMARY

Remove all references to onyx from collection towards merging to a new collection

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

[felixfontein]

@samerd please update https://github.com/ansible/ansible/blob/devel/lib/ansible/config/ansible_builtin_runtime.yml so that it points the modules to the correct location.

[felixfontein]

You need to add redirect statements to meta/runtime.yml for every removed module, so that the modules can still be called via this collection:

    onyx_<xxx>:
      deprecation:
        removal_version: 3.0.0
        warning_text: The onyx_<xxx> module has been moved to the <namespace>.<name> collection
      redirect: <namespace>.<name>.onyx_<xxx>

(You need similar entries for the plugins in new entries in plugin_routing.)

[felixfontein]

I'm not really sure how this works, but I think there also need to be redirects for:

1. the plugins (terminal and cliconf);
2. the docs fragment;
3. Python import redirects for module_utils.

I have really no idea whether a redirect is needed for the action plugin, or whether that's covered by the module...

[felixfontein]

@samerd could you please change the removal version to 2.0.0? We discussed this and decided to remove the leftovers earlier, since this should affect only pre-1.0.0 users.

[samerd]

@samerd could you please change the removal version to 2.0.0? We discussed this and decided to remove the leftovers earlier, since this should affect only pre-1.0.0 users.

sure will do

[samerd]

@felixfontein : please review
I changed the removal version

[felixfontein]

There's something strange going on here. GitHub shows that the PR contains a lot of changes that are already in master. Could you try rebasing? (Or is this a GitHub bug?)

[samerd]

Closing and opening a new clean PR