Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deprecations #63

Merged

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

This adjusts the deprecation versions as decided in the community working group meeting (https://meetbot.fedoraproject.org/ansible-community/2020-06-10/community_working_group.2020-06-10-18.04.html), and adjusts the ignore.txt entries.

It also removes some F5 modules which according to https://github.com/ansible/ansible/blob/devel/lib/ansible/config/ansible_builtin_runtime.yml have been moved to the F5 collection.

Then it adjusts the deprecations which were scheduled for removal in Ansible 2.9 for removal in 0.2.0 (next released version), and adds ignore.txt entries for these.

Finally, it comments out the aci_intf_policy_port_* deprecation entries in meta/runtime.yml sind according to the modules themselves, they are not deprecated. @gundalow do you know where the deprecation entries come from?

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

collection

Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where the other entries came from, maybe we can merge this then follow up with rest next week?

@felixfontein
Copy link
Collaborator Author

I used https://gist.github.com/felixfontein/964068eed7e8d233f77abe097eef31a7 to clean up meta/runtime.yml and remove some modules that have apparently been moved somewhere else meanwhile.

@felixfontein
Copy link
Collaborator Author

@gundalow these aci_intf_policy_port_* modules are redirects to the aci_interface_policy_* modules, which have been moved to cisco.aci. I've removed the traces; I'll create a PR to update ansible/ansible's ansible_builtin_runtime.yml.

@felixfontein
Copy link
Collaborator Author

(See ansible/ansible#70051)

@felixfontein
Copy link
Collaborator Author

CC @Andersson007

…lections in ansible/ansible's lib/ansible/config/ansible_builtin_runtime.yml.
aci_intf_policy_fc.py -> aci_interface_policy_fc.py
aci_intf_policy_l2.py -> aci_interface_policy_l2.py
aci_intf_policy_lldp.py -> aci_interface_policy_lldp.py
aci_intf_policy_mcp.py -> aci_interface_policy_mcp.py
aci_intf_policy_port_channel.py -> aci_interface_policy_port_channel.py
aci_intf_policy_port_security.py -> aci_interface_policy_port_security.py
@felixfontein felixfontein force-pushed the adjust-deprecations branch from 43a7cb2 to f39f769 Compare June 15, 2020 19:23
@felixfontein felixfontein merged commit 914d117 into ansible-collections:master Jun 16, 2020
@felixfontein felixfontein deleted the adjust-deprecations branch June 16, 2020 08:06
@felixfontein
Copy link
Collaborator Author

@gundalow @Andersson007 thanks a lot for reviewing this! :)

@Andersson007
Copy link
Contributor

Andersson007 commented Jun 16, 2020

Yw,
just in case, if i were you, i'd also run grep -r "Ansible 2.10" plugins/ | grep -v " # was " with 2.11, 2.12, 2.13, 2.14 in community.network as i did in ansible-collections/community.general#504

@Andersson007
Copy link
Contributor

grep -r "Ansible 2.1[0-4]" ...

@felixfontein
Copy link
Collaborator Author

@Andersson007 found nothing in this repo.

@Andersson007
Copy link
Contributor

@felixfontein cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants