-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up deprecations #63
Clean up deprecations #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where the other entries came from, maybe we can merge this then follow up with rest next week?
I used https://gist.github.com/felixfontein/964068eed7e8d233f77abe097eef31a7 to clean up meta/runtime.yml and remove some modules that have apparently been moved somewhere else meanwhile. |
@gundalow these aci_intf_policy_port_* modules are redirects to the aci_interface_policy_* modules, which have been moved to cisco.aci. I've removed the traces; I'll create a PR to update ansible/ansible's ansible_builtin_runtime.yml. |
(See ansible/ansible#70051) |
…lections in ansible/ansible's lib/ansible/config/ansible_builtin_runtime.yml.
…uiltin_runtime.yml.
aci_intf_policy_fc.py -> aci_interface_policy_fc.py aci_intf_policy_l2.py -> aci_interface_policy_l2.py aci_intf_policy_lldp.py -> aci_interface_policy_lldp.py aci_intf_policy_mcp.py -> aci_interface_policy_mcp.py aci_intf_policy_port_channel.py -> aci_interface_policy_port_channel.py aci_intf_policy_port_security.py -> aci_interface_policy_port_security.py
43a7cb2
to
f39f769
Compare
@gundalow @Andersson007 thanks a lot for reviewing this! :) |
Yw, |
|
@Andersson007 found nothing in this repo. |
@felixfontein cool |
SUMMARY
This adjusts the deprecation versions as decided in the community working group meeting (https://meetbot.fedoraproject.org/ansible-community/2020-06-10/community_working_group.2020-06-10-18.04.html), and adjusts the ignore.txt entries.
It also removes some F5 modules which according to https://github.com/ansible/ansible/blob/devel/lib/ansible/config/ansible_builtin_runtime.yml have been moved to the F5 collection.
Then it adjusts the deprecations which were scheduled for removal in Ansible 2.9 for removal in 0.2.0 (next released version), and adds ignore.txt entries for these.
Finally, it comments out the aci_intf_policy_port_* deprecation entries in meta/runtime.yml sind according to the modules themselves, they are not deprecated. @gundalow do you know where the deprecation entries come from?
ISSUE TYPE
COMPONENT NAME
collection