Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql_replication: fix crashes caused by deprecated terminology #71

Merged
merged 14 commits into from
Dec 18, 2020
Merged

mysql_replication: fix crashes caused by deprecated terminology #71

merged 14 commits into from
Dec 18, 2020

Conversation

Andersson007
Copy link
Collaborator

SUMMARY

Fixes #70

mysql_replication: fix crashes caused by deprecated terminology

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/mysql_replication.py

@Andersson007 Andersson007 force-pushed the mysql_replication_change_terminology branch from 1d5430f to e07e96b Compare December 9, 2020 08:29
@codecov
Copy link

codecov bot commented Dec 9, 2020 •
edited
Loading

Codecov Report

Merging #71 (14a4a2d) into main (d309d5a) will increase coverage by 0.87%.
The diff coverage is 88.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   71.46%   72.33%   +0.87%     
==========================================
  Files           8        9       +1     
  Lines        1570     1605      +35     
  Branches      414      420       +6     
==========================================
+ Hits         1122     1161      +39     
+ Misses        301      298       -3     
+ Partials      147      146       -1
Impacted Files Coverage Δ
plugins/modules/mysql_replication.py 70.27% <85.29%> (+2.10%) ⬆️
...sts/unit/plugins/modules/test_mysql_replication.py 94.73% <94.73%> (ø)
plugins/modules/mysql_user.py 70.68% <0.00%> (+0.55%) ⬆️
plugins/module_utils/mysql.py 81.57% <0.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d309d5a...14a4a2d. Read the comment docs.

@Andersson007
Copy link
Collaborator Author

Andersson007 commented Dec 9, 2020 •
edited
Loading

the integration and sanity tests are passed, so

  • add / change integration (and maybe unit) tests to cover added code
  • add a changelog fragment

@Andersson007
Copy link
Collaborator Author

mysql 8.0.22 failed because my code properly changed SLAVE to REPLICA. Adjusted the tests.

@Andersson007 Andersson007 force-pushed the mysql_replication_change_terminology branch from 4ea498c to c85e320 Compare December 10, 2020 10:21
@Andersson007 Andersson007 force-pushed the mysql_replication_change_terminology branch from c85e320 to 3d2661b Compare December 10, 2020 10:28
@Andersson007 Andersson007 changed the title [DRAFT] mysql_replication: fix crashes caused by deprecated terminology mysql_replication: fix crashes caused by deprecated terminology Dec 10, 2020
@Andersson007 Andersson007 mentioned this pull request Dec 10, 2020
Closed
@Andersson007
Copy link
Collaborator Author

cc @Alexander198961 @michaelcoburn @Oneiroi @tolland @Xyon @kurtdavis @bmalynovytch @bmildren @Jorge-Rodriguez

@Andersson007
Copy link
Collaborator Author

FYI: the tests with 8.0.21 were also green

@Andersson007 Andersson007 mentioned this pull request Dec 11, 2020
Closed
@Andersson007
Copy link
Collaborator Author

ready_for_review

@Andersson007 Andersson007 mentioned this pull request Dec 16, 2020
Merged
@Andersson007
Copy link
Collaborator Author

@felixfontein thanks for reviewing!

@Andersson007 Andersson007 mentioned this pull request Dec 18, 2020
Closed
@Andersson007 Andersson007 merged commit ebe5038 into ansible-collections:main Dec 18, 2020
@Andersson007
Copy link
Collaborator Author

@felixfontein thanks for reviewing!

@Andersson007 Andersson007 mentioned this pull request Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mysql_replication: terminology updates, "SLAVE" is deprecated
2 participants
@Andersson007 @felixfontein