Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql_role: add examples for "members_must_exist" argument #376

Conversation

betanummeric
Copy link
Member

mysql_role

add documentation for the members_must_exist argument

see PR #369, issue #366

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #376 (2590917) into main (bf5086d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   78.10%   78.10%           
=======================================
  Files          27       27           
  Lines        2279     2279           
  Branches      552      552           
=======================================
  Hits         1780     1780           
  Misses        340      340           
  Partials      159      159           
Impacted Files Coverage Δ
plugins/modules/mysql_role.py 85.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5086d...2590917. Read the comment docs.

Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@betanummeric thanks for the PR! One small formatting thing

plugins/modules/mysql_role.py Outdated Show resolved Hide resolved
plugins/modules/mysql_role.py Outdated Show resolved Hide resolved
betanummeric and others added 2 commits May 27, 2022 14:29
Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andersson007 Andersson007 merged commit 05eccd9 into ansible-collections:main May 30, 2022
@Andersson007
Copy link
Collaborator

@betanummeric thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants