Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PSF-license.txt file #356

Merged
merged 2 commits into from
May 16, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

plugins/module_utils/_version.py mentions PSF-license.txt, which doesn't exist yet.

Please make sure to create new releases with this ASAP.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

licenses

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #356 (4c2f974) into main (f62d708) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   78.23%   78.23%           
=======================================
  Files          27       27           
  Lines        2270     2270           
  Branches      551      551           
=======================================
  Hits         1776     1776           
  Misses        335      335           
  Partials      159      159           
Impacted Files Coverage Δ
plugins/module_utils/_version.py 41.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62d708...4c2f974. Read the comment docs.

Copy link
Contributor

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would squash these commits, but the content of the PR looks okay, so this is approved (although I don't think my approval actually counts for anything).

@felixfontein
Copy link
Collaborator Author

@gotmax23 PRs are squashed on merge anyway.

@gotmax23
Copy link
Contributor

@gotmax23 PRs are squashed on merge anyway.

Fair enough. I thought that might be the case.

@Andersson007
Copy link
Collaborator

Fixes #357

@Andersson007 Andersson007 merged commit b2e476c into ansible-collections:main May 16, 2022
@Andersson007
Copy link
Collaborator

@felixfontein thanks for the fix!
@gotmax23 thanks for reviewing!

@felixfontein felixfontein deleted the psf-license branch May 16, 2022 10:21
felixfontein added a commit to felixfontein/community.mysql that referenced this pull request May 16, 2022
* Add PSF-license.txt file.

* Update with actual CPython 3.9.5 license.

(cherry picked from commit b2e476c)
felixfontein added a commit to felixfontein/community.mysql that referenced this pull request May 16, 2022
* Add PSF-license.txt file.

* Update with actual CPython 3.9.5 license.

(cherry picked from commit b2e476c)
@felixfontein
Copy link
Collaborator Author

I created manual backports in #359 and #360.

Andersson007 pushed a commit that referenced this pull request May 17, 2022
* Add PSF-license.txt file.

* Update with actual CPython 3.9.5 license.

(cherry picked from commit b2e476c)
Andersson007 pushed a commit that referenced this pull request May 17, 2022
* Add PSF-license.txt file.

* Update with actual CPython 3.9.5 license.

(cherry picked from commit b2e476c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants