mysql_user: prevent password getting set for existing users on on_cre… #342

hubiongithub · 2022-05-05T14:22:49Z

…ate when plugin is used

SUMMARY

if update_password is set to on_create the code did not update "password" but update "plugin,plugin_auth_string,plugin_hash_string"

From my point of view "on_create" should never update a password related value.

This change has the side effect that a change of the plugin (lets say caching_sha2_password -> auth_pam (which requires no plugin_auth_string at all) will not happen.

Fixes #334

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

mysql_user

ADDITIONAL INFORMATION

hubiongithub · 2022-05-06T12:25:26Z

I canvnot view the result from this third-party-check status: failure
I could not get the tests working here behind an outgoing proxy as apt runs inside (the ansible-test -docker) containers and apt does not accept HTTP_PROXY environment and I would have to set these proxy parameter inside /etc/apt/apt-conf.d/.00_proxy.conf in all containers which ansible-test generates and running apt add key ... in. And I don't know how to do this.

codecov · 2022-05-06T12:48:53Z

Codecov Report

Merging #342 (f7cc26d) into main (c489cf1) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   78.23%   78.10%   -0.14%     
==========================================
  Files          27       27              
  Lines        2270     2279       +9     
  Branches      551      552       +1     
==========================================
+ Hits         1776     1780       +4     
- Misses        335      340       +5     
  Partials      159      159

Impacted Files	Coverage Δ
plugins/modules/mysql_user.py	`81.44% <ø> (ø)`
plugins/modules/mysql_role.py	`85.66% <0.00%> (-1.72%)`	⬇️
plugins/modules/mysql_query.py	`88.17% <0.00%> (+1.58%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c489cf1...f7cc26d. Read the comment docs.

Andersson007 · 2022-05-06T13:03:22Z

@hubiongithub thanks for the PR!
I'll try to take a look at the changes and your comment at the beginning of next week.

Could you please also add a changelog gragment?

Andersson007 · 2022-05-09T08:39:47Z

changelogs/fragments/334-mysql_user_fix_logic_on_oncreate.yml

+  - "mysql_user - fix logicwhen update_password is set to on_create for users using plugin* arguments (https://github.com/ansible-collections/community.mysql/issues/334)."
+
+


Suggested change

- "mysql_user - fix logicwhen update_password is set to on_create for users using plugin* arguments (https://github.com/ansible-collections/community.mysql/issues/334)."

- "mysql_user - fix logic when ``update_password`` is set to ``on_create`` for users using ``plugin*`` arguments (https://github.com/ansible-collections/community.mysql/issues/334)."

Andersson007 · 2022-05-25T06:47:28Z

@hubiongithub sorry for the late reply, busy days.., could you please rebase the PR and fix the changelog fragment? About rebasing, here's the guide. As it's for ansible core, it uses the devel branch. Use main instead. Thanks!

@betanummeric @rsicart @Jorge-Rodriguez do you have experience in using these arguments? I'd be great to hear opinions of folks who use this feature

…ate when plugin is used

betanummeric · 2022-05-25T07:24:38Z

I have not used the plugin, plugin_auth_string, plugin_hash_string arguments yet, but I might start soon, for which I would need this PR too. Regardless of my potential usecase, this PR looks good to me. Some integration tests could be added.

hubiongithub · 2022-05-25T07:44:45Z

Rebase of PR to main: done
Format fixing of changelog fragment: done and pushed

changelogs/fragments/334-mysql_user_fix_logic_on_oncreate.yml

plugins/modules/mysql_user.py

Andersson007 · 2022-05-25T08:25:28Z

@hubiongithub Could you also please clarify the documentation for corresponding arguments according to the change? (i would also suggest elaborating a bit on details in the changelog fragment's entry)

changelogs/fragments/334-mysql_user_fix_logic_on_oncreate.yml

…_auth_string options, format fix on changelog

Andersson007

you can just click commit suggestion

plugins/modules/mysql_user.py

Co-authored-by: Andrew Klychkov <[email protected]>

…hub/community.mysql into issue334_fix_logic_on_oncreate

changelogs/fragments/334-mysql_user_fix_logic_on_oncreate.yml

plugins/modules/mysql_user.py

Andersson007

another linting issue

plugins/modules/mysql_user.py

Andersson007 · 2022-05-31T05:41:54Z

@hubiongithub thanks for the contribution! The community will be happy to see more from you!
@betanummeric thanks for reviewing!

Andersson007 · 2022-05-31T05:46:11Z

@hubiongithub there are conflicts which need to be solved, so the automatic backporting is not possible. Would you like to backport your changes manually to stable-2 and stable-1 branches? See this guide.
If you have no time, please let me know, i'll do it myself, np.

hubiongithub · 2022-05-31T08:29:25Z

I followed the steps from the patchback instructions above, I hope I didn't missed anything.

Andersson007 · 2022-05-31T10:16:59Z

@hubiongithub i replied in #379 (comment)

Andersson007 · 2022-05-31T10:31:40Z

@hubiongithub what i usually do #379 (comment)

ansible-collections#342) Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit 51a3884)

#342) (#382) Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit 51a3884) Co-authored-by: hubiongithub <[email protected]>

Andersson007 reviewed May 9, 2022

View reviewed changes

hubiongithub added 2 commits May 25, 2022 09:22

mysql_user: prevent password getting set for existing users on on_cre…

8e84ef2

…ate when plugin is used

added changelog fragment

bcbb620

hubiongithub force-pushed the issue334_fix_logic_on_oncreate branch from f004806 to bcbb620 Compare May 25, 2022 07:37

format fix

907892e

Andersson007 reviewed May 25, 2022

View reviewed changes

changelogs/fragments/334-mysql_user_fix_logic_on_oncreate.yml Outdated Show resolved Hide resolved

plugins/modules/mysql_user.py Outdated Show resolved Hide resolved

hubiongithub added 2 commits May 25, 2022 12:21

added substract_privs, to t list of arguments

955d274

clarify the documetation

df9be2f

Andersson007 reviewed May 25, 2022

View reviewed changes

changelogs/fragments/334-mysql_user_fix_logic_on_oncreate.yml Outdated Show resolved Hide resolved

additional documentation to password,plugin,plugin_hash_string,plugin…

23b1777

…_auth_string options, format fix on changelog

Andersson007 reviewed May 25, 2022

View reviewed changes

plugins/modules/mysql_user.py Outdated Show resolved Hide resolved

plugins/modules/mysql_user.py Outdated Show resolved Hide resolved

plugins/modules/mysql_user.py Outdated Show resolved Hide resolved

hubiongithub and others added 5 commits May 28, 2022 08:07

Update plugins/modules/mysql_user.py

65e56f3

Co-authored-by: Andrew Klychkov <[email protected]>

Update plugins/modules/mysql_user.py

837e2e0

Co-authored-by: Andrew Klychkov <[email protected]>

Update plugins/modules/mysql_user.py

ce1a404

Co-authored-by: Andrew Klychkov <[email protected]>

linting

a0aa029

Merge branch 'issue334_fix_logic_on_oncreate' of github.com:hubiongit…

b2eec45

…hub/community.mysql into issue334_fix_logic_on_oncreate

Andersson007 reviewed May 30, 2022

View reviewed changes

changelogs/fragments/334-mysql_user_fix_logic_on_oncreate.yml Outdated Show resolved Hide resolved

linting

b931cd7

Andersson007 reviewed May 30, 2022

View reviewed changes

plugins/modules/mysql_user.py Outdated Show resolved Hide resolved

linting

4d6cacb

Andersson007 reviewed May 30, 2022

View reviewed changes

plugins/modules/mysql_user.py Outdated Show resolved Hide resolved

linting

f7cc26d

Andersson007 approved these changes May 31, 2022

View reviewed changes

Andersson007 merged commit 51a3884 into ansible-collections:main May 31, 2022

Andersson007 added backport-2 labels May 31, 2022

ansible-collections deleted a comment from patchback bot May 31, 2022

hubiongithub deleted the issue334_fix_logic_on_oncreate branch May 31, 2022 08:29

Andersson007 mentioned this pull request May 31, 2022

mysql_user expires password on second run #295

Closed

hubiongithub mentioned this pull request May 31, 2022

Patchback/backports/stable 1/51a38840d977e6184be3ef1d6f427c8cb3dc4545/pr 342 #379

Closed

Andersson007 mentioned this pull request May 31, 2022

[stable-2] mysql_user: prevent password getting set for existing users on on_cre… #382

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mysql_user: prevent password getting set for existing users on on_cre… #342

mysql_user: prevent password getting set for existing users on on_cre… #342

hubiongithub commented May 5, 2022

hubiongithub commented May 6, 2022

codecov bot commented May 6, 2022 •

edited

Loading

Andersson007 commented May 6, 2022

Andersson007 May 9, 2022

Andersson007 commented May 25, 2022

betanummeric commented May 25, 2022 •

edited

Loading

hubiongithub commented May 25, 2022

Andersson007 commented May 25, 2022 •

edited

Loading

Andersson007 left a comment

Andersson007 left a comment

Andersson007 commented May 31, 2022

Andersson007 commented May 31, 2022

hubiongithub commented May 31, 2022

Andersson007 commented May 31, 2022

Andersson007 commented May 31, 2022

		- "mysql_user - fix logicwhen update_password is set to on_create for users using plugin* arguments (https://github.com/ansible-collections/community.mysql/issues/334)."

	- "mysql_user - fix logicwhen update_password is set to on_create for users using plugin* arguments (https://github.com/ansible-collections/community.mysql/issues/334)."
	- "mysql_user - fix logic when ``update_password`` is set to ``on_create`` for users using ``plugin*`` arguments (https://github.com/ansible-collections/community.mysql/issues/334)."

mysql_user: prevent password getting set for existing users on on_cre… #342

mysql_user: prevent password getting set for existing users on on_cre… #342

Conversation

hubiongithub commented May 5, 2022

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

hubiongithub commented May 6, 2022

codecov bot commented May 6, 2022 • edited Loading

Codecov Report

Andersson007 commented May 6, 2022

Andersson007 May 9, 2022

Choose a reason for hiding this comment

Andersson007 commented May 25, 2022

betanummeric commented May 25, 2022 • edited Loading

hubiongithub commented May 25, 2022

Andersson007 commented May 25, 2022 • edited Loading

Andersson007 left a comment

Choose a reason for hiding this comment

Andersson007 left a comment

Choose a reason for hiding this comment

Andersson007 commented May 31, 2022

Andersson007 commented May 31, 2022

hubiongithub commented May 31, 2022

Andersson007 commented May 31, 2022

Andersson007 commented May 31, 2022

codecov bot commented May 6, 2022 •

edited

Loading

betanummeric commented May 25, 2022 •

edited

Loading

Andersson007 commented May 25, 2022 •

edited

Loading