-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IF EXISTS clause to DROP USER statement #307
Conversation
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
==========================================
- Coverage 78.31% 78.25% -0.07%
==========================================
Files 27 27
Lines 2246 2249 +3
Branches 527 527
==========================================
+ Hits 1759 1760 +1
- Misses 331 333 +2
Partials 156 156
Continue to review full report at Codecov.
|
@rsicart could you please take a look? (if you're ok with the change, feel free to merge it ignoring the codecov failings as i don't think we can cover the changes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@rsicart thanks for reviewing! |
* Add IF EXISTS clause to DROP USER statement * Add a changelog fragment * Fix exception (cherry picked from commit 3a452fa)
SUMMARY
Fixes #286
ISSUE TYPE