Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IF EXISTS clause to DROP USER statement #307

Merged
merged 3 commits into from
Mar 15, 2022

Conversation

Andersson007
Copy link
Collaborator

SUMMARY

Fixes #286

ISSUE TYPE
  • Bugfix Pull Request

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #307 (8ccffe3) into main (1f16e65) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   78.31%   78.25%   -0.07%     
==========================================
  Files          27       27              
  Lines        2246     2249       +3     
  Branches      527      527              
==========================================
+ Hits         1759     1760       +1     
- Misses        331      333       +2     
  Partials      156      156              
Impacted Files Coverage Δ
plugins/module_utils/user.py 86.97% <50.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f16e65...8ccffe3. Read the comment docs.

@Andersson007
Copy link
Collaborator Author

@rsicart could you please take a look? (if you're ok with the change, feel free to merge it ignoring the codecov failings as i don't think we can cover the changes)

Copy link
Contributor

@rsicart rsicart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rsicart rsicart merged commit 3a452fa into ansible-collections:main Mar 15, 2022
@Andersson007
Copy link
Collaborator Author

@rsicart thanks for reviewing!

Andersson007 added a commit to Andersson007/community.mysql that referenced this pull request Mar 15, 2022
* Add IF EXISTS clause to DROP USER statement

* Add a changelog fragment

* Fix exception

(cherry picked from commit 3a452fa)
Andersson007 added a commit that referenced this pull request Mar 15, 2022
* Add IF EXISTS clause to DROP USER statement

* Add a changelog fragment

* Fix exception

(cherry picked from commit 3a452fa)
@rsicart rsicart mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants