mysql_db: Fix assert in tests suite #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Payart <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 77.61% 77.61%
=======================================
Files 24 24
Lines 2171 2171
Branches 510 510
=======================================
Hits 1685 1685
Misses 319 319
Partials 167 167 Continue to review full report at Codecov.
|
Andersson007
approved these changes
Oct 25, 2021
Andersson007
pushed a commit
to Andersson007/community.mysql
that referenced
this pull request
Nov 29, 2021
Signed-off-by: Nicolas Payart <[email protected]> (cherry picked from commit 5522e45)
Andersson007
added a commit
that referenced
this pull request
Nov 29, 2021
* Allow the "%" character in database name (#227) The naming rules for MySQL/MariaDB identifiers, when quoted, allow the `%` character. However, currently, the use of the `%` character in database names results in mismatch or missing databases. - Rewrite query to identify the databases in the catalog using `information_schema` instead of `SHOW DATABASES LIKE` - Escape the `%` character in `CREATE DATABASE` query. Signed-off-by: Nicolas Payart <[email protected]> (cherry picked from commit 6b12435) * mysql_db: Fix assert in tests suite (#239) Signed-off-by: Nicolas Payart <[email protected]> (cherry picked from commit 5522e45) * mysql_db: Improve tests (#240) - Define variables "db_names" and "db_formats" in defaults - Use of the "vars" option in includes instead of default parameters that might be overridden by a previous task - Use of the "loop" option in includes instead of duplicating include tasks - Use a nested loop on db_names and db_formats in state_dump_import test Signed-off-by: Nicolas Payart <[email protected]> (cherry picked from commit e4de13a) * MAINTAINERS file: Add new maintainer (#248) (cherry picked from commit d411a8e) Co-authored-by: Nicolas PAYART <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In the
encoding_dump_importtest suite of themysql_dbmodule, the "assert" tasks check the wrong variable.register(L.81) expected by the next assert (L.85)ISSUE TYPE
COMPONENT NAME
mysql_db