-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql_query: correctly reflect changed status in replace statements #193
mysql_query: correctly reflect changed status in replace statements #193
Conversation
Codecov Report
@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 76.92% 76.92%
=======================================
Files 20 20
Lines 1794 1794
Branches 439 439
=======================================
Hits 1380 1380
Misses 268 268
Partials 146 146
Continue to review full report at Codecov.
|
@unnecessary-username hi, thanks for the contribution!
you can click on |
tests/integration/targets/test_mysql_query/tasks/mysql_query_initial.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@unnecessary-username thanks for the contribution! We have a lot to do, so would be nice if you continue your contribution here:) |
See our issue tracker and PRs. We'd be grateful for any ideas / opinions / fixes / etc. |
Thanks @Andersson007 :) I am not an expert in MySQL but I will spend some time to see if anything else I could contribute to. |
@unnecessary-username frankly speaking, I'm not an expert too:) Ok, thank you! |
…nsible-collections#193) * mysql_query: correctly reflect changed status in replace statements. * Fix the wrong indent. (cherry picked from commit 9055bb4)
…193) (#195) * mysql_query: correctly reflect changed status in replace statements. * Fix the wrong indent. (cherry picked from commit 9055bb4) Co-authored-by: Tong He <[email protected]>
…nsible-collections#193) * mysql_query: correctly reflect changed status in replace statements. * Fix the wrong indent. (cherry picked from commit 9055bb4)
…193) (#197) * mysql_query: correctly reflect changed status in replace statements. * Fix the wrong indent. (cherry picked from commit 9055bb4) Co-authored-by: Tong He <[email protected]>
SUMMARY
There is a replace statement in MySQL and mariadb. Currently running replace statements works well except that the changed status is always false.
So I add REPLACE as a DML_QUERY_KEYWORDS and I supplement test cases for this.
ISSUE TYPE
COMPONENT NAME
mysql_query
ADDITIONAL INFORMATION