Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql: revert changes made in PR 116 #153

Merged
merged 7 commits into from
Apr 23, 2021
Merged

mysql: revert changes made in PR 116 #153

merged 7 commits into from
Apr 23, 2021

Conversation

Andersson007
Copy link
Collaborator

@Andersson007 Andersson007 commented Apr 23, 2021 •
edited
Loading

SUMMARY

mysql: revert changes made in PR #116

relates to #116 and #151

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/mysql.py

@codecov
Copy link

codecov bot commented Apr 23, 2021 •
edited
Loading

Codecov Report

Merging #153 (16e273b) into main (c8f9b1c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   76.92%   76.92%           
=======================================
  Files          20       20           
  Lines        1794     1794           
  Branches      439      439           
=======================================
  Hits         1380     1380           
  Misses        268      268           
  Partials      146      146
Impacted Files Coverage Δ
plugins/module_utils/mysql.py 83.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f9b1c...16e273b. Read the comment docs.

@Andersson007 Andersson007 mentioned this pull request Apr 23, 2021
Closed
@Andersson007
Copy link
Collaborator Author

cc @Jorge-Rodriguez

Jorge-Rodriguez
Jorge-Rodriguez approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@Jorge-Rodriguez Jorge-Rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So Ansible devel is python 3.8 only now?

@Andersson007
Copy link
Collaborator Author

So Ansible devel is python 3.8 only now?

Good question. Let's wait for updates a bit.
If there's no any updates how to cope with it until next week, we should start figuring out how to fix them.

@Andersson007
Copy link
Collaborator Author

@Jorge-Rodriguez if you know a quick solution, welcome.

@Andersson007 Andersson007 merged commit 738343d into ansible-collections:main Apr 23, 2021
Andersson007 added a commit to Andersson007/community.mysql that referenced this pull request Apr 23, 2021
@Andersson007
mysql: revert changes made in PR 116 (ansible-collections#153)
4f9e3eb 
* mysql: revert changes made in PR 116

* Add changelog fragment

* Fix CI

* Fix CI

* Fix CI

* Update CI

* Fix CI

(cherry picked from commit 738343d)
@Andersson007 Andersson007 mentioned this pull request Apr 23, 2021
Merged
Andersson007 added a commit to Andersson007/community.mysql that referenced this pull request Apr 23, 2021
@Andersson007
mysql: revert changes made in PR 116 (ansible-collections#153)
8514e90 
* mysql: revert changes made in PR 116

* Add changelog fragment

* Fix CI

* Fix CI

* Fix CI

* Update CI

* Fix CI

(cherry picked from commit 738343d)
This was referenced Apr 23, 2021
Merged
Merged
@Jorge-Rodriguez
Copy link
Contributor

Jorge-Rodriguez commented Apr 23, 2021 •
edited
Loading

@Jorge-Rodriguez if you know a quick solution, welcome.

It should be possible to exclude the matrix branches for older python versions and Ansible devel

I can do that. I'm planning to tweak the job matrix to include MariaDB.

Andersson007 added a commit that referenced this pull request Apr 23, 2021
@Andersson007
mysql: revert changes made in PR 116 (#153) (#155)
34a300d 
* mysql: revert changes made in PR 116

* Add changelog fragment

* Fix CI

* Fix CI

* Fix CI

* Update CI

* Fix CI

(cherry picked from commit 738343d)
Andersson007 added a commit that referenced this pull request Apr 23, 2021
@Andersson007
mysql: revert changes made in PR 116 (#153) (#156)
fe8f366 
* mysql: revert changes made in PR 116

* Add changelog fragment

* Fix CI

* Fix CI

* Fix CI

* Update CI

* Fix CI

(cherry picked from commit 738343d)
@mgedmin mgedmin mentioned this pull request Jun 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorge-Rodriguez Jorge-Rodriguez Jorge-Rodriguez approved these changes

Assignees
No one assigned
Labels
needs_backport_to_stable-1 needs_backport_to_stable-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andersson007 @Jorge-Rodriguez