mysql_replication: Add aliases to "master" options, add alternatives to "master" state options, add announcement #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, announce major changes
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
- Coverage 79.11% 76.92% -2.20%
==========================================
Files 20 20
Lines 3194 1794 -1400
Branches 815 439 -376
==========================================
- Hits 2527 1380 -1147
+ Misses 412 268 -144
+ Partials 255 146 -109
Continue to review full report at Codecov.
|
Andersson007
changed the title
Jorge-Rodriguez
suggested changes
Apr 19, 2021
Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <[email protected]>
Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <[email protected]>
|
@Jorge-Rodriguez thanks, committed, ready for review |
Jorge-Rodriguez
approved these changes
Apr 19, 2021
bmalynovytch
approved these changes
Apr 20, 2021
|
@Jorge-Rodriguez @bmalynovytch thanks for reviewing! |
Andersson007
added a commit
to Andersson007/community.mysql
that referenced
this pull request
Apr 23, 2021
…to "master" state options, add announcement (ansible-collections#150) * mysql_replication: Add aliases, add alternatives for the state option, announce major changes * Change tests * Add changelog fragment * Fix changelog * Update plugins/modules/mysql_replication.py Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <[email protected]> * Update plugins/modules/mysql_replication.py Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <[email protected]> Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <[email protected]> (cherry picked from commit c8f9b1c)
Andersson007
added a commit
that referenced
this pull request
Apr 23, 2021
…to "master" state options, add announcement (#150) (#152) * mysql_replication: Add aliases, add alternatives for the state option, announce major changes * Change tests * Add changelog fragment * Fix changelog * Update plugins/modules/mysql_replication.py Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <[email protected]> * Update plugins/modules/mysql_replication.py Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <[email protected]> Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <[email protected]> (cherry picked from commit c8f9b1c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Relates to #145
mysql_replication:
stateoptionsImportant: this does NOT contain any breaking changes. I ran the not touched tests with the changes - they passed. Then changed, the changed ones also passed (but you can recheck if any doubts, just checkout to the first commit of the PR).