Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issues highlighted in #477 #483

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Address issues highlighted in #477 #483

merged 2 commits into from
Jul 19, 2022

Conversation

rhysmeister
Copy link
Collaborator

SUMMARY
  • Use extended FQCN for pam_limits (community.general.system.pam_limits instead of community.general.pam_limits)
  • Remove upper bound restriction for community.general collection
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • mongodb_linux role
  • galaxy.yml
  • CI Workflows

@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #483 (86c031c) into master (67756e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   84.27%   84.27%           
=======================================
  Files           2        2           
  Lines         515      515           
  Branches       75       75           
=======================================
  Hits          434      434           
  Misses         57       57           
  Partials       24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67756e7...86c031c. Read the comment docs.

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Definitely needs a changelog entry though, but I don't know how you add these in this collection :)

@rhysmeister
Copy link
Collaborator Author

Looks good. Definitely needs a changelog entry though, but I don't know how you add these in this collection :)

It'll get one when I do a release. Cheers!

@rhysmeister rhysmeister merged commit e3e6a66 into master Jul 19, 2022
@rhysmeister rhysmeister deleted the 477_pamlimits branch July 19, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants