Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Add test for openshift apply bug #94

Merged
merged 1 commit into from
May 21, 2020

Conversation

willthames
Copy link
Collaborator

SUMMARY

Add a failing test under openshift 0.11.0

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

k8s/raw

@willthames
Copy link
Collaborator Author

Ready to merge once openshift/openshift-restclient-python#362 is merged and released

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   42.98%   42.98%           
=======================================
  Files           3        3           
  Lines         542      542           
  Branches      110      110           
=======================================
  Hits          233      233           
  Misses        266      266           
  Partials       43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7b552...00200cf. Read the comment docs.

@willthames
Copy link
Collaborator Author

The test failures here are nothing to do with my code

@geerlingguy
Copy link
Collaborator

@willthames can you rebase on master? The pytest issue has been fixed.

@willthames willthames force-pushed the apply_nested_dict branch from 8e3bc31 to c25d567 Compare May 19, 2020 13:56
@willthames
Copy link
Collaborator Author

@geerlingguy done

@geerlingguy
Copy link
Collaborator

@willthames - And of course quay.io is down currently 🤷‍♂️ — I'll try to rerun the tests after things are back up.

@willthames willthames force-pushed the apply_nested_dict branch from c25d567 to 873fca2 Compare May 21, 2020 01:31
@willthames willthames force-pushed the apply_nested_dict branch from 873fca2 to 00200cf Compare May 21, 2020 02:39
@geerlingguy
Copy link
Collaborator

It seems like tests are passing here, even if they're not passing on the main repo currently :-/ See #104

@geerlingguy geerlingguy self-requested a review May 21, 2020 18:16
Copy link
Collaborator

@geerlingguy geerlingguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I wonder if the race condition fix you added will resolve #104?

@geerlingguy geerlingguy requested a review from fabianvf May 21, 2020 18:16
Copy link
Collaborator

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fabianvf fabianvf merged commit 3bdfb47 into ansible-collections:master May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants