-
Notifications
You must be signed in to change notification settings - Fork 104
Add test for openshift apply bug #94
Add test for openshift apply bug #94
Conversation
Ready to merge once openshift/openshift-restclient-python#362 is merged and released |
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 42.98% 42.98%
=======================================
Files 3 3
Lines 542 542
Branches 110 110
=======================================
Hits 233 233
Misses 266 266
Partials 43 43 Continue to review full report at Codecov.
|
The test failures here are nothing to do with my code |
@willthames can you rebase on master? The pytest issue has been fixed. |
8e3bc31
to
c25d567
Compare
@geerlingguy done |
@willthames - And of course quay.io is down currently 🤷♂️ — I'll try to rerun the tests after things are back up. |
c25d567
to
873fca2
Compare
Fails using 0.11.0
873fca2
to
00200cf
Compare
It seems like tests are passing here, even if they're not passing on the main repo currently :-/ See #104 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and I wonder if the race condition fix you added will resolve #104?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SUMMARY
Add a failing test under openshift 0.11.0
ISSUE TYPE
COMPONENT NAME
k8s/raw