This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
warn about disclosure when using certain options #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanemcd
reviewed
Mar 11, 2020
| @@ -65,6 +65,7 @@ | |||
| kubectl_extra_args: | |||
| description: | |||
| - Extra arguments to pass to the kubectl command line. | |||
| - Please be aware that this passes information directly on the command line and it could expose sensitive data. | |||
There was a problem hiding this comment.
Should you add the We recommend using the file based authentication options instead. here too?
There was a problem hiding this comment.
Guess not? Looks like this was just merged.
There was a problem hiding this comment.
my bad, though I think the password/api key are the only sensitive auth bits you can pass in plain text that you need to work around with file based auth, the other kubectl options are either just paths to files or not sensitive AFAIK
This comment has been minimized.
This comment has been minimized.
|
backport ansible/ansible#68195 |
This was referenced Apr 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
some options push data inline into cli, this is not good when using secrets and can lead to disclosure
CVE-2020-1753
ISSUE TYPE
COMPONENT NAME
kubectl