This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Do not mark task as changed when diff is irrelevant #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the diff contains changes only to the fields `metadata.generation` or `metadata.resourceVersion`, do not mark the task as changed. Instead, emit a warning highlighting that the API itself may not be idempotent, but that there was no meaningful difference between the desired and actual state of the resource.
Codecov Report
@@ Coverage Diff @@
## main #228 +/- ##
==========================================
- Coverage 43.38% 42.66% -0.72%
==========================================
Files 4 4
Lines 597 607 +10
Branches 118 122 +4
==========================================
Hits 259 259
- Misses 291 301 +10
Partials 47 47
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When the diff contains changes only to the fields
metadata.generationor
metadata.resourceVersion, do not mark the task as changed. Instead,emit a warning highlighting that the API itself may not be
idempotent, but that there was no meaningful difference between the
desired and actual state of the resource.
ISSUE TYPE
COMPONENT NAME
plugins/modules/k8s.py
ADDITIONAL INFORMATION