Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Issue #53: Add probot/stale bot configuration to ID and close stale issues. #196

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Issue #53: Add probot/stale bot configuration to ID and close stale issues. #196

merged 1 commit into from
Aug 24, 2020

Conversation

geerlingguy
Copy link
Collaborator

Closes #53.

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #196 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   41.90%   41.90%           
=======================================
  Files           3        3           
  Lines         556      556           
  Branches      114      114           
=======================================
  Hits          233      233           
  Misses        279      279           
  Partials       44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3dd21b...7acd460. Read the comment docs.

Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tima
Copy link
Collaborator

tima commented Aug 20, 2020

LGTM also.

@geerlingguy Do we need to add any additional labels or will the probot handle label creation?

@tima tima self-requested a review August 20, 2020 23:03
@fabianvf fabianvf merged commit fec3d17 into ansible-collections:main Aug 24, 2020
@geerlingguy
Copy link
Collaborator Author

@tima - If we want to add certain new labels to mark issues as 'not stale permanently', we would need to add those labels to the bot config. Right now it's just:

exemptLabels:
   - pinned
   - security
   - planned
   - priority/critical
   - verified

@tima
Copy link
Collaborator

tima commented Aug 24, 2020

@geerlingguy

  • priority/critical
  • verified

OK. We have these already.

  • security
  • planned

These could be useful. I'll add these.

  • pinned

Not sure what we'd use this one for.

@fabianvf
Copy link
Collaborator

@tima I think pinned would likely be equivalent to lifecycle/frozen, which generally means "This is a real issue, it should not be closed. It is not high priority (or can't be worked on yet), and it is not currently on the list of planned work." Basically an issue that could be sitting around for a few months to a year or more, but it would be bad if it was forgotten

@geerlingguy
Copy link
Collaborator Author

Ah, in that case I'll add that as another tag to use for ignoring stale.

geerlingguy added a commit that referenced this pull request Aug 27, 2020
PR #196 follow-up: Adjust stale bot exemptLabels.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Probot/stale bot to mark issues as stale and close after certain period
4 participants